Skip to content
This repository has been archived by the owner on Dec 12, 2023. It is now read-only.

Enable peerDependencies in typings.json #20

Merged
merged 1 commit into from
Mar 5, 2016
Merged

Conversation

blakeembrey
Copy link
Member

These dependencies act like devDependencies (E.g. install locally, don’t install when used as a dependency) but can be semantically separated for later logging, etc.

  • Enabled additional flags for init
  • Tidied up install and uninstall utils from fs

Closes typings/typings#203

These dependencies act like `devDependencies` (E.g. install locally, don’t install when used as a dependency) but can be semantically separated for later logging, etc. 

* Enabled additional flags for `init`
* Tidied up install and uninstall utils from `fs`
@blakeembrey blakeembrey merged commit 0eb4c47 into master Mar 5, 2016
@blakeembrey blakeembrey deleted the enable-peer-deps branch March 5, 2016 03:25
@arlair
Copy link

arlair commented Mar 6, 2016

Is this always on, or meant to be optionally configured in tsconfig.json?

I have a weird hack case that may not be worth considering because I am using an npm package, but not the peer dependencies. Currently Typings (0.6.10) checks for the peer dependencies existence and creating an error when they are not found.

See eldarlabs/cycle-ui#2

Previously I thought I had read Typings only installs types for the npm package and not any child dependencies, but this pull seems to suggest otherwise. If this peer dependency behaviour is opt in, it probably doesn't need to be doing this check.

@blakeembrey
Copy link
Member Author

This is for peerDependencies in typings.json. package.json has always resolved peer dependencies for NPM dependencies to get the type information. If that doesn't sound right, please make an issue on the Typings repo so we can figure out how to improve this flow. However, if you reference it in your code you need to make sure types exist for it.

Edit: I'll submit another PR to make it act more like ambient dependencies, and you can give me feedback for 0.7 of Typings.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants