Introduce notification after uninstallation #289
Conversation
|
Ummm.... I do not know why this test fails when only stable. This test passes in my local environment... ( |
|
The build failure has been fixed, I've noticed some random failures lately but haven't been able to test them thoroughly. As for the PR, the work will need to be ported to https://github.com/typings/core. However, it should be simpler to build the feature there, since I've enabled a messaging pipeline for use during installation/uninstall/etc. |
| @@ -278,8 +278,18 @@ export function removeDependency (options: DefinitionOptions) { | |||
|
|
|||
| // Remove the dependency from typings. | |||
| function remove (path: string, file: string, dtsFile: string) { | |||
| return promiseFinally(rimraf(path), () => { | |||
| return transformDtsFile(dtsFile, typings => typings.filter(x => x !== file)) | |||
| const libName: string = path.split('/').slice(-1)[0] | |||
There was a problem hiding this comment.
We can't just split on / because Windows uses a different separator. It'd probably be easier to just get the options passed through.
There was a problem hiding this comment.
const obj: any = require('path').parse(file)
const dir: string = obj.dir
const libName: string = obj.name.split('.')[0]
console.log(dir, libName);
output
/Users/hoge/typings/typings/main/definitions/jquery jquery
/Users/hoge/typings/typings/browser/definitions/jquery jquery
Would this be ok?
There was a problem hiding this comment.
The name is already available from the passed in options in the outer scope. It's probably easier to use that instead of trying to parse it yourself.
|
Ok, it's done and will be released with 0.7. It looks like:
|
Hello :)
I added a log after uninstallation.
if a file exists
if a file does not exist
Please give me words if an upper sentence is not good :)
I will modify the following PR.
#15
#177
thanks.