[BUGFIX] Allow to update DB schema without ext_tables.php

Classes/Core/Booting/RunLevel.php

@@ -163,10 +163,10 @@ protected function buildExtendedRuntimeSequence()
     {
         $sequence = $this->buildBasicRuntimeSequence(self::LEVEL_FULL);
 
+        // @deprecated can be removed if TYPO3 8 support is removed
         $this->addStep($sequence, 'helhum.typo3console:database');
         // Fix core caches that were disabled beforehand
         $this->addStep($sequence, 'helhum.typo3console:enablecorecaches');
-        $this->addStep($sequence, 'helhum.typo3console:persistence');
         $this->addStep($sequence, 'helhum.typo3console:authentication');
 
         return $sequence;
@@ -214,12 +214,10 @@ protected function addStep($sequence, $stepIdentifier)
             case 'helhum.typo3console:enablecorecaches':
                 $sequence->addStep(new Step('helhum.typo3console:enablecorecaches', [\Helhum\Typo3Console\Core\Booting\Scripts::class, 'reEnableOriginalCoreCaches']), 'helhum.typo3console:database');
                 break;
+            // @deprecated can be removed if TYPO3 8 support is removed
             case 'helhum.typo3console:database':
                 $sequence->addStep(new Step('helhum.typo3console:database', [\Helhum\Typo3Console\Core\Booting\Scripts::class, 'initializeDatabaseConnection']), 'helhum.typo3console:errorhandling');
                 break;
-            case 'helhum.typo3console:persistence':
-                $sequence->addStep(new Step('helhum.typo3console:persistence', [\Helhum\Typo3Console\Core\Booting\Scripts::class, 'initializePersistence']), 'helhum.typo3console:extensionconfiguration');
-                break;
             case 'helhum.typo3console:authentication':
                 $sequence->addStep(new Step('helhum.typo3console:authentication', [\Helhum\Typo3Console\Core\Booting\Scripts::class, 'initializeAuthenticatedOperations']), 'helhum.typo3console:extensionconfiguration');
                 break;

Classes/Core/Booting/Scripts.php

@@ -152,27 +152,20 @@ public static function initializeExtensionConfiguration(ConsoleBootstrap $bootst
     {
         ExtensionManagementUtility::loadExtLocalconf();
         $bootstrap->applyAdditionalConfigurationSettings();
+        $bootstrap->loadTcaOnly();
     }
 
     /**
      * @param ConsoleBootstrap $bootstrap
      */
-    public static function initializePersistence(ConsoleBootstrap $bootstrap)
+    public static function initializeAuthenticatedOperations(ConsoleBootstrap $bootstrap)
     {
         if (is_callable([$bootstrap, 'loadExtTables'])) {
-            $bootstrap->loadBaseTca();
             $bootstrap->loadExtTables();
         } else {
             // @deprecated can be removed once TYPO3 7.6 support is removed
-            $bootstrap->loadExtensionTables();
+            $bootstrap->loadExtTablesOnly();
         }
-    }
-
-    /**
-     * @param ConsoleBootstrap $bootstrap
-     */
-    public static function initializeAuthenticatedOperations(ConsoleBootstrap $bootstrap)
-    {
         $bootstrap->initializeBackendUser(CommandLineUserAuthentication::class);
         self::loadCommandLineBackendUser();
         // Global language object on CLI? rly? but seems to be needed by some scheduler tasks :(

Classes/Core/ConsoleBootstrap.php

@@ -367,13 +367,32 @@ public function initializeConfigurationManagement()
         $this->defineUserAgentConstant();
     }
 
+    /**
+     * @deprecated can be removed if TYPO3 7 support is removed (directly use $bootstrap->loadBaseTca())
+     */
+    public function loadTcaOnly()
+    {
+        Utility\ExtensionManagementUtility::loadBaseTca();
+    }
+
+    /**
+     * @deprecated can be removed if TYPO3 7 support is removed (directly use $bootstrap->loadExtTables())
+     */
+    public function loadExtTablesOnly()
+    {
+        Utility\ExtensionManagementUtility::loadExtTables();
+        $this->executeExtTablesAdditionalFile();
+        $this->runExtTablesPostProcessingHooks();
+    }
+
+    /**
+     * @deprecated can be removed if TYPO3 7 support is removed
+     */
     public function initializeDatabaseConnection()
     {
-        // @deprecated can be removed if TYPO3 7 support is removed
         if (is_callable([$this, 'defineDatabaseConstants'])) {
             $this->defineDatabaseConstants();
         }
-        // @deprecated can be removed if TYPO3 7 support is removed
         if (is_callable([$this, 'initializeTypo3DbGlobal'])) {
             $this->initializeTypo3DbGlobal();
         }

Classes/Install/CliSetupRequestHandler.php

@@ -153,6 +153,7 @@ public function setup($interactiveSetup, array $givenRequestArguments)
         }
         // Flush caches, as the extension list has changed
         $this->commandDispatcher->executeCommand('cache:flush', ['--files-only' => true]);
+        $this->commandDispatcher->executeCommand('database:updateschema');
         $this->commandDispatcher->executeCommand('extension:setupactive');
         $this->output->outputLine('<success>OK</success>');
     }

Configuration/Console/Commands.php

@@ -33,7 +33,6 @@
         'typo3_console:cache:flush' => ['helhum.typo3console:database'],
         'typo3_console:database:updateschema' => [
             'helhum.typo3console:database',
-            'helhum.typo3console:persistence',
         ],
     ],
 ];

Tests/Functional/Command/AbstractCommandTest.php

@@ -184,7 +184,7 @@ protected function executeComposerCommand(array $arguments = [], array $environm
         $process = $processBuilder->setTimeout(null)->getProcess();
         $process->run();
         if (!$process->isSuccessful()) {
-            $this->fail(sprintf('Composer command failed with message: "%s", output: "%s"', $process->getErrorOutput(), $process->getOutput()));
+            $this->fail(sprintf('Composer command "%s" failed with message: "%s", output: "%s"', $process->getCommandLine(), $process->getErrorOutput(), $process->getOutput()));
         }
         return $process->getOutput() . $process->getErrorOutput();
     }