[BUGFIX] Don't create folders for extensions any more

Classes/Console/Command/Install/InstallFixFolderStructureCommand.php

@@ -16,11 +16,10 @@
 
 use Helhum\Typo3Console\Command\AbstractConvertedCommand;
 use Helhum\Typo3Console\Command\RelatableCommandInterface;
-use Helhum\Typo3Console\Install\FolderStructure\ExtensionFactory;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
-use TYPO3\CMS\Core\Package\PackageManager;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
+use TYPO3\CMS\Install\FolderStructure\DefaultFactory;
 
 class InstallFixFolderStructureCommand extends AbstractConvertedCommand implements RelatableCommandInterface
 {
@@ -72,16 +71,17 @@ protected function handleDeprecatedArgumentsAndOptions(InputInterface $input, Ou
      */
     protected function execute(InputInterface $input, OutputInterface $output)
     {
-        $folderStructureFactory = new ExtensionFactory(GeneralUtility::makeInstance(PackageManager::class));
-        $fixedStatusObjects = $folderStructureFactory
+        $folderStructureFactory = GeneralUtility::makeInstance(DefaultFactory::class);
+        $messages = $folderStructureFactory
             ->getStructure()
-            ->fix();
+            ->fix()
+            ->getAllMessagesAndFlush();
 
-        if (empty($fixedStatusObjects)) {
+        if (empty($messages)) {
             $output->writeln('<info>No action performed!</info>');
         } else {
             $output->writeln('<info>The following directory structure has been fixed:</info>');
-            foreach ($fixedStatusObjects as $fixedStatusObject) {
+            foreach ($messages as $fixedStatusObject) {
                 $output->writeln($fixedStatusObject->getTitle());
             }
         }

Classes/Console/Extension/ExtensionSetup.php

@@ -15,23 +15,16 @@
  */
 
 use Helhum\Typo3Console\Database\Schema\SchemaUpdateType;
-use Helhum\Typo3Console\Install\FolderStructure\ExtensionFactory;
 use Helhum\Typo3Console\Service\CacheService;
 use Helhum\Typo3Console\Service\Database\SchemaService;
 use TYPO3\CMS\Core\Package\PackageInterface;
-use TYPO3\CMS\Core\Package\PackageManager;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 use TYPO3\CMS\Core\Utility\PathUtility;
 use TYPO3\CMS\Extbase\Object\ObjectManager;
 use TYPO3\CMS\Extensionmanager\Utility\InstallUtility;
 
 class ExtensionSetup
 {
-    /**
-     * @var ExtensionFactory
-     */
-    private $extensionFactory;
-
     /**
      * @var InstallUtility
      */
@@ -48,12 +41,10 @@ class ExtensionSetup
     private $extensionConfiguration;
 
     public function __construct(
-        ExtensionFactory $extensionFactory = null,
         InstallUtility $extensionInstaller = null,
         SchemaService $schemaService = null,
         ExtensionConfiguration $extensionConfiguration = null
     ) {
-        $this->extensionFactory = $extensionFactory ?? new ExtensionFactory(GeneralUtility::makeInstance(PackageManager::class));
         $this->extensionInstaller = $extensionInstaller ?? GeneralUtility::makeInstance(ObjectManager::class)->get(InstallUtility::class);
         $this->schemaService = $schemaService ?? GeneralUtility::makeInstance(ObjectManager::class)->get(SchemaService::class);
         $this->extensionConfiguration = $extensionConfiguration ?? new ExtensionConfiguration();
@@ -83,7 +74,6 @@ public function deactivateExtensions(array $packageKeys)
     public function setupExtensions(array $packages)
     {
         foreach ($packages as $package) {
-            $this->extensionFactory->getExtensionStructure($package)->fix();
             $this->callInstaller('importInitialFiles', [PathUtility::stripPathSitePrefix($package->getPackagePath()), $package->getPackageKey()]);
             $this->extensionConfiguration->saveDefaultConfiguration($package->getPackageKey());
         }

Resources/Private/ExtensionArtifacts/ext_emconf.php

@@ -4,8 +4,6 @@
   'description' => 'A reliable and powerful command line interface for TYPO3 CMS',
   'category' => 'cli',
   'state' => 'stable',
-  'uploadfolder' => 0,
-  'createDirs' => '',
   'modify_tables' => '',
   'clearCacheOnLoad' => 0,
   'author' => 'Helmut Hummel',

Tests/Console/Functional/Fixtures/Extensions/ext_broken_ext_tables/ext_emconf.php

@@ -4,8 +4,6 @@
   'description' => 'Extension fixture to prove extension compat check is working correctly',
   'category' => 'cli',
   'state' => 'stable',
-  'uploadfolder' => 0,
-  'createDirs' => '',
   'modify_tables' => '',
   'clearCacheOnLoad' => 0,
   'author' => 'Helmut Hummel',

Tests/Console/Functional/Fixtures/Extensions/ext_broken_sql/ext_emconf.php

@@ -4,8 +4,6 @@
   'description' => 'Extension fixture to prove extension setup working correctly',
   'category' => 'cli',
   'state' => 'stable',
-  'uploadfolder' => 0,
-  'createDirs' => '',
   'modify_tables' => '',
   'clearCacheOnLoad' => 0,
   'author' => 'Helmut Hummel',

Tests/Console/Functional/Fixtures/Extensions/ext_config/ext_emconf.php

@@ -4,8 +4,6 @@
   'description' => 'Extension fixture to prove extension setup working correctly',
   'category' => 'cli',
   'state' => 'stable',
-  'uploadfolder' => 0,
-  'createDirs' => '',
   'modify_tables' => '',
   'clearCacheOnLoad' => 0,
   'author' => 'Helmut Hummel',

Tests/Console/Functional/Fixtures/Extensions/ext_no_dep/ext_emconf.php

@@ -4,8 +4,6 @@
   'description' => 'Extension fixture to prove generating package states working correctly',
   'category' => 'cli',
   'state' => 'stable',
-  'uploadfolder' => 0,
-  'createDirs' => '',
   'modify_tables' => '',
   'clearCacheOnLoad' => 0,
   'author' => 'Helmut Hummel',

Tests/Console/Functional/Fixtures/Extensions/ext_test/ext_emconf.php

@@ -4,8 +4,6 @@
   'description' => 'Extension fixture to prove extension setup working correctly',
   'category' => 'cli',
   'state' => 'stable',
-  'uploadfolder' => 0,
-  'createDirs' => '',
   'modify_tables' => '',
   'clearCacheOnLoad' => 0,
   'author' => 'Helmut Hummel',

Tests/Console/Functional/Fixtures/Extensions/ext_test_cache/ext_emconf.php

@@ -4,8 +4,6 @@
   'description' => 'Extension fixture to prove extension setup working correctly',
   'category' => 'cli',
   'state' => 'stable',
-  'uploadfolder' => 0,
-  'createDirs' => '',
   'modify_tables' => '',
   'clearCacheOnLoad' => 0,
   'author' => 'Helmut Hummel',

Tests/Console/Functional/Fixtures/Extensions/ext_upgrade/ext_emconf.php

@@ -4,8 +4,6 @@
   'description' => 'Extension fixture to prove upgrade working correctly',
   'category' => 'cli',
   'state' => 'stable',
-  'uploadfolder' => 0,
-  'createDirs' => '',
   'modify_tables' => '',
   'clearCacheOnLoad' => 0,
   'author' => 'Helmut Hummel',

Tests/Console/Functional/Fixtures/Extensions/ext_with_dep/ext_emconf.php

@@ -4,8 +4,6 @@
   'description' => 'Extension fixture to prove generating package states working correctly',
   'category' => 'cli',
   'state' => 'stable',
-  'uploadfolder' => 0,
-  'createDirs' => '',
   'modify_tables' => '',
   'clearCacheOnLoad' => 0,
   'author' => 'Helmut Hummel',