Lint lib/ #89
Merged
Lint lib/ #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The carriers file contains duplicate keys. They have been resolved: - exact duplicate of ideacellular deleted - exact duplicate of onlinebeep deleted - one duplicate of surewestcommunications (%s@freesurf.ch) renamed to sunrisecommunications as www.freesurf.ch redirects to sunrise.ch Unused variables were defined in the library. They have been resolved: - reference to the `underscore` module deleted - reference to the `exec` function of the `child_process` module deleted The carrier argument in text.send was not documented in the library code. That line of documentation has been added. The carrier argument in text.send was not being checked as strictly equal to null. The triple-equals operator has now been applied to the comparison. The requires had bad line breakings before commas. The commas have all been moved to ends of lines instead. On an unrelated not to lint, the console.log call in the text library has been switched out with an output call to obey the debug setting.
|
Thanks very much, Valter, this is long overdue for a cleanup 👍 |
|
Yeah, I noticed there are a lot of rough edges. This PR was just implementing the suggestions by JSHint in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The carriers file contains duplicate keys. They have been resolved:
Unused variables were defined in the library. They have been resolved:
underscoremodule deletedexecfunction of thechild_processmodule deletedThe carrier argument in text.send was not documented in the library code. That line of documentation has been added.
The carrier argument in text.send was not being checked as strictly equal to null. The triple-equals operator has now been applied to the comparison.
The requires had bad line breakings before commas. The commas have all been moved to ends of lines instead.
On an unrelated not to lint, the console.log call in the text library has been switched out with an output call to obey the debug setting.