Add subsequent Param to Name::is_supressed
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will be used to fix typst/typst#2874
|
Thank you! (I updated the description in the PR so merging does not close typst/hayagriva#111 just yet) |
Thank you for catching that! |
|
One more quick question: To use this in hayagriva, citationberg needs a new release. Should it be a major one? This is technically a breaking change. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will be used in fixing bug typst/hayagriva#111
This PR adds a parameter to
Name::is_supressed, which allows a different behavior when writing names for a subsequent citation, per the name options in the CSL spec.After merging, I will update hayagriva accordingly.