Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix figure centering #4276

Merged
merged 2 commits into from
May 29, 2024
Merged

Fix figure centering #4276

merged 2 commits into from
May 29, 2024

Conversation

laurmaedje
Copy link
Member

@laurmaedje laurmaedje commented May 28, 2024

show figure: set align(..) now works as expected.

This might break users who assume that show figure: it => it.body is equivalent to just it.body, since it doesn't revoke the centering anymore (just like show heading: it => it.body doesn't revoke the heading styling).

cc: @sahasatvik, author of ctheorems which is likely affected

laurmaedje and others added 2 commits May 28, 2024 17:22
`show figure: set align(..)` now works as expected.

This might break users who assume that `show figure: it => it.body` fully resets the styling, since it doesn't revoke the centering (just like `show heading: it => it.body` doesn't revoke the heading styling).

Co-Authored-By: PgBiel <9021226+PgBiel@users.noreply.github.com>
@laurmaedje laurmaedje enabled auto-merge May 29, 2024 13:14
@laurmaedje laurmaedje added this pull request to the merge queue May 29, 2024
Merged via the queue into main with commit e6739ec May 29, 2024
12 checks passed
@laurmaedje laurmaedje deleted the fix-figure-centering branch May 29, 2024 13:36
PgBiel added a commit to tulio240/typst that referenced this pull request May 30, 2024
Refactor frame metadata into tags (typst#4212)


Require `Send` and `Sync` for worlds (typst#4219)


Optimize counters and state (typst#4223)


Add `windows` method to array (typst#4136)

Improve `CITATION.cff` file (typst#4201)


Fix equation resizing when adding the equation number (typst#4179)


`layout` documentation improvements (typst#4196)

Allow somewhat arbitrary characters as `mat`, `vec` and `cases` `delim` (typst#4211)


Do layout short-circuit in flow instead of realization (typst#4231)


Split `BitSet` into two types and make it a bit nicer (typst#4249)


Set default value of `raw.theme` to `auto`, and allow setting `raw.theme` to `auto` (typst#4186)


Extended cargo installation instructions (typst#4168)

Hint for language-region pair on `text.lang` (typst#4183)


Improve macro docs (+ Native*Data docs) (typst#4240)


Rephrase the sentence on variable scope in Scripting documentation (typst#4250)


Refactor `Capable::vtable` to return `Option<NonNull<()>>` (typst#4252)


Nicer test helper CSS (typst#4269)


Trim weak spacing at line start/end in paragraph layout (typst#4087)


Add ability to choose between minified and pretty-printed JSON (typst#4161)


Refactor PDF export (typst#4154)

Reorder syntax kinds (typst#4287)


Fix figure centering (typst#4276)

Fix `Default` impls for AST nodes (typst#4288)


Bump libc to v0.2.155 (typst#4268)


Bump time dependency (typst#4294)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant