Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Security upgrade @xmldom/xmldom from 0.8.3 to 0.8.4 #138

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

tyrasd
Copy link
Owner

@tyrasd tyrasd commented Nov 3, 2022

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

merge advice

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • package.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Priority Score (*) Issue Breaking Change Exploit Maturity
high severity 823/1000
Why? Proof of Concept exploit, Recently disclosed, Has a fix available, CVSS 8.6
Improper Input Validation
SNYK-JS-XMLDOMXMLDOM-3092934
No Proof of Concept

(*) Note that the real score may have changed since the PR was raised.

Commit messages
Package name: @xmldom/xmldom The new version differs by 3 commits.

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

@@ -28,7 +28,7 @@
},
"dependencies": {
"@mapbox/geojson-rewind": "0.5.2",
"@xmldom/xmldom": "0.8.3",
"@xmldom/xmldom": "0.8.4",
Copy link

@kachkaev kachkaev Jan 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest version is 0.8.6 at the time of writing: https://www.npmjs.com/package/@xmldom/xmldom?activeTab=versions

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the exact version of @xmldom/xmldom important? Why not ^0.8.4, which would have allowed projects that depend on osmtogeojson to upgrade the version to a non-vulnerable one without changing this repo?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. There aren’t any reported vulnerabilities in 0.8.4 and 0.8.5 (at least now): https://security.snyk.io/package/npm/@xmldom%2Fxmldom

Using ^0.8.4 would do!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kachkaev Please note that I'm not a maintainer of this package. I'm just wondering, as I'm here for the same reason as you (critical vulnerability in our project), but no other dependency is noted with ^ in this package. They all use exact versions.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. That's a reason why I’ve flagged the existence of 0.8.6. If the versions have to be fixed, it’s best to use the latest available just in case.

@mwenko
Copy link

mwenko commented Aug 2, 2023

Is there any chance this PR gets merged soon? 🙏

@matthiasfeist
Copy link

@kachkaev or @tahini any updates here? anything I could help with to get this merged?

@devinmatte
Copy link

@tyrasd Any chance this could be merged and deployed to NPM anytime soon? It would be great to resolve this vulnerability

@tahini
Copy link

tahini commented Jun 28, 2024

I opened a new more recent PR to fix this issue (#146). We are trying to get rid of the critical security issues in our project and that would be really helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants