New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ES6 modules, use webpack bundler (cont.) #283
Conversation
(without resorting to preloading all presets)
mocking ajax code still missing
which includes for example route relation handling (as MultiLineStrings)
js/ide.js
Outdated
@@ -7,7 +7,7 @@ import CodeMirror from 'codemirror/lib/codemirror.js'; | |||
import moment from 'moment'; | |||
import tokml from 'tokml'; | |||
import togpx from 'togpx'; | |||
import * as _saveAs from 'file-saver'; | |||
import {saveAs} from 'file-saver'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. I couldn't find out how to get this to run properly on the weekend. I still have to get used to the new import syntax 🤷♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The best introduction into ES6 modules I've found is the chapter in Exploring ES6.
`npm test` or `npm run test:start`
Required for older browsers and tests on PhantomJS.
Jay, all tests finally succeed. I also removed the For publishing, I'd recommend the NPM package gh-pages. Its usage is as simple as |
Great! Thanks for the effort, Simon! Is it correct that now everything is done except for the publishing step (which I'll take a look at asap – and thanks for the tip with the gh-pages package)? |
Now, copying the For running |
Somehow this change seems to have broken the shortlink feature: the share button only produces lengthy URLs rather than the /s/xyz redirect. |
@mmd-osm thanks for spotting that! I think I probably just forgot to set the respective setting when re-deploying on overpass-turbo.eu. |
it should work again now. let me know if you find any more regressions. 👍 |
I'm not sure about this one. There's a "/missing translation/" shown instead of some German text in Autorun mode: http://overpass-turbo.eu/s/oSq |
👍 It's a regression. And I see this also in the English UI. |
(temporary) workaround for #283 (comment)
Here's another one... [bbox:{{bbox}}];
node[place=village];
out;
{{style:
node{
text: eval('tag("name")');
}
}} Fails with: Error while evaluating mapcss evals TypeError: o.a.evalparser is undefined |
Hmmm.. somehow, a recent deployment broke the shortlink feature again. |
oops. 🙈 It should now work again. |
There's still something wrong with the new deployment: overpass-turbo.eu reports as "(beta)", and all of my saved queries are gone in the meantime - even the |
sorry again, I really have to fix up my deploy scripts 😒 It should work again now.
Are you sure? I don't think that's something that could have happened only by me messing up the build parameters here. For me, my saved queries are accessible again now. |
Great, thanks a lot for the quick fix!
Yes, you're right. I only looked at the Firefox dev tools, which seems to limit the variable length. All good in turbo now. |
continuation of #282 (moving onto a branch on the main github repo for easier collaboration @simon04).
export
/import
index.html
)map.html
)*_packaged.html
files