CI: Migrate to GitHub Actions #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyru
reviewed
Apr 19, 2020
.github/workflows/reviewdog.yml
Outdated
Comment on lines
20
to
35
| vimlint: | ||
| name: runner / vimlint | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v1 | ||
| - name: Vimlint | ||
| uses: tsuyoshicho/action-vimlint@v1 | ||
| with: | ||
| github_token: ${{ secrets.github_token }} | ||
| - name: Vimlint-pr-review | ||
| uses: tsuyoshicho/action-vimlint@v1 | ||
| if: github.event_name == 'pull_request' | ||
| with: | ||
| github_token: ${{ secrets.github_token }} | ||
| reporter: github-pr-review |
| @@ -470,7 +470,7 @@ function! s:write_all() abort | |||
| silent edit `=dir.'/caw.vim'` | |||
| silent %delete _ | |||
| silent read macros/after-ftplugin-template.vim | |||
| silent 1delete _ | |||
| silent 1g/^$/delete _ | |||
There was a problem hiding this comment.
純粋な疑問なんですが :read で1行目に空行以外が入ることってありましたっけ？
There was a problem hiding this comment.
vim を -e オプション付きで実行すると1行目が空行にならない (:read したファイルと同内容になる) ので、-e あり／なし 両対応にしています。
| run: | | ||
| rm -rf after/ftplugin/ | ||
| bash -x macros/generate-ftplugins.sh | ||
| test -z "$(git status -s | tee >(cat >&2))" |
There was a problem hiding this comment.
出力ファイルを cat >&2 へのパイプにしています。
git status -s の結果をログにも出したかったのでこのようにしています。
ichizok
force-pushed
the
feature/gh-actions
branch
from
5405c0a
to
9975eed
Compare
|
マージする順番ミスったかもしれませんが、コンフリクトしてるので修正お願いします:bow: |
ichizok
force-pushed
the
feature/gh-actions
branch
from
9975eed
to
5927b26
Compare
|
修正しました。 |
tyru
approved these changes
Apr 20, 2020
|
ありがとうございました！ |
|
マージコミットでAppVeyorがNGになっていますが、明示的に止める必要があるんでしょうか？ |
|
@ichizok はい、ちょうど気になって色々試してたのですが、AppVeyor 側で止める必要があったみたいです（キャッシュがあって数分消えなかったですが無事消えました） |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vim-jp/vital.vim#701 から拝借しました。
タスクは適当に分割しています。