Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate entries in b:undo_ftplugin #47

Closed
wants to merge 13 commits into from
Closed

Fix duplicate entries in b:undo_ftplugin #47

wants to merge 13 commits into from

Conversation

tyru
Copy link
Owner

@tyru tyru commented Mar 23, 2016

Fixed #46 problem.

Changes

From the merge commit log

  • Fix ftplugin template (macros/after-ftplugin-template.vim)
    • Do not append an entry to b:undo_ftplugin if b:did_caw_ftplugin was defined
  • Regenerate after/ftplugin/**/*.vim according to fixed template
  • Use 'maint' branch of 'tyru/vmock'
  • Bump themis version: v1.5 -> v1.5.1
  • Add unlet! b:did_caw_ftplugin to actions.* tests

TODO

  1. I should also :unlet! for b:did_caw_ftplugin?
  2. Investigate a problem that AppVeyor build fails
  3. Upgrade to themis version (This should fix above problem?)
    • Upgraded to v1.5.1 but no luck
  4. comment from @machakann in バッファを閉じた(:q)ときに E108 #46
    • Wrap b:undo_ftplugin check with checking b:did_* variable? -> Success

@tyru
Fix ftplugin template
e04e589 
Check "b:did_caw_<FILETYPE>_ftplugin".
@tyru
Regenerate after/ftplugin/{filetype}/caw.vim
eeb44b2 
vim -u NONE -i NONE -n -N -S macros/separate.vim -c quit
@tyru
Fix failed tests
b2d91b3
@tyru tyru mentioned this pull request Mar 23, 2016
Closed
@tyru
Copy link
Owner Author

tyru commented Mar 23, 2016

Updated TODO

@tyru tyru changed the title Fix/dup entries undo ftplugin Fix duplicate entries on b:undo_ftplugin Mar 24, 2016
@tyru tyru changed the title Fix duplicate entries on b:undo_ftplugin Fix duplicate entries in b:undo_ftplugin Mar 24, 2016
@tyru tyru closed this in e3d84c2 Mar 24, 2016
tyru added a commit that referenced this pull request Mar 24, 2016
@tyru
Fix duplicate entries in b:undo_ftplugin (close #47)
1a7db62 
* Fix ftplugin template (`macros/after-ftplugin-template.vim`)
  * Do not append an entry to `b:undo_ftplugin` if `b:did_caw_ftplugin` was defined
* Regenerate `after/ftplugin/**/*.vim` according to fixed template
* Use 'maint' branch of 'tyru/vmock'
* Bump themis version: v1.5 -> v1.5.1
* Add `unlet! b:did_caw_ftplugin` to `actions.*` tests

Thanks @machakann, @thinca
@tyru
Copy link
Owner Author

tyru commented Mar 24, 2016

Translate issue comment to English.

@tyru tyru deleted the fix/dup-entries-undo_ftplugin branch March 24, 2016 15:25
@tyru
Copy link
Owner Author

tyru commented Mar 24, 2016

Merged with --squash.
And I confirmed errors disappear in users' environments (in Twitter, Lingr)
so deleted the branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

バッファを閉じた(:q)ときに E108
1 participant
@tyru