Make :OpenGitHubIssue and :OpenGitHubPullReq look under the cursor #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhysd
force-pushed
the
issue-number-under-cursor
branch
2 times, most recently
from
321bd9c
to
dbb115b
Compare
tyru
requested changes
May 26, 2017
autoload/openbrowser/github.vim
Outdated
| @@ -180,13 +180,23 @@ function! s:cmd_open_url(args, type) | |||
| " Both '#1' and '1' are supported. | |||
| let number = matchstr(get(a:args, 0, ''), '^#\?\zs\d\+\ze$') | |||
|
|
|||
| " If the issue number is omitted, the index of argument of repository will | |||
| " become 0 (a:args[0]), otherwise 1 (a:args[1]) | |||
| let repos_arg_index = number == '' ? 0 : 1 | |||
autoload/openbrowser/github.vim
Outdated
| return '' | ||
| endif | ||
|
|
||
| " Emit first '#' |
There was a problem hiding this comment.
emit はなんか違うような。
get rid of とか prune ですかね？
|
Fixed. |
|
ヤッター！🎉 言い忘れましたが、かなり便利みの高い PR でした！ |
rhysd
added a commit
to rhysd/open-browser-github.vim
that referenced
this pull request
May 28, 2017
tyru
added a commit
that referenced
this pull request
Jun 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
カーソル下が
#数字だった場合，その issue（または pull request）番号のページを開くようにしました．コード内に修正した該当 issue 番号が書いてあることが結構あって，そこを直接開きたいことが結構あったので実装しました．番号からだけでは issue か pull request か判断できないのですが，GitHub 側で適宜リダイレクトされると思うので良いかなと思っています．一応手元では動作確認済みです with 8.0-329 on macOS 10.12