Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re sizing label/option size result in white boarder instead? #87

Closed
Jerry-Yocupco opened this issue Dec 31, 2014 · 6 comments
Closed

Re sizing label/option size result in white boarder instead? #87

Jerry-Yocupco opened this issue Dec 31, 2014 · 6 comments

Comments

@Jerry-Yocupco
Copy link

Seem like by making the label/options size smaller than the defaulted 40 would create white boarder instead of actually shrinking the label size? the actual label seem to be offset to the top left.
capture2

Also, it is possible to include the option text after the option title, for say, Color_, into Color_: Red
The 1.9.1 native swatch have this function already so I think it maybe an easy add on?

@oviliz
Copy link

oviliz commented Dec 31, 2014

You should be able to fix the white border via CSS. Is there a setting as
well but didn't work to me when I've tried time ago.
On 31 Dec 2014 19:15, "Jerry-Yocupco" notifications@github.com wrote:

Seem like by making the label/options size smaller than the defaulted 40
would create white boarder instead of actually shrinking the label size?
the actual label seem to be offset to the top left.
[image: capture2]
https://cloud.githubusercontent.com/assets/8918594/5589905/dd6f9154-90dd-11e4-8a03-e6cc5da76fd1.PNG

Also, it is possible to include the option text after the option title,
for say, Color_, into Color_: Red

The 1.9.1 native swatch have this function already so I think it maybe an
easy add on?


Reply to this email directly or view it on GitHub
#87.

@tzyganu
Copy link
Owner

tzyganu commented Jan 1, 2015

@Jerry-Yocupco @oviliz the resize part is sort of an unfinished feature. I totally forgot about it.
youu can resize the images but in the css file still the width and height of the box are still 40px.
I'll see what I can do in the next version.
As for the color name after the label...I will try to do that but it's not very high priority.

@oviliz
Copy link

oviliz commented Jan 1, 2015

I'm sure that I've done that via CSS.
The "...50px!important" should help.
On 1 Jan 2015 10:38, "Marius Strajeru" notifications@github.com wrote:

@Jerry-Yocupco https://github.com/Jerry-Yocupco @oviliz
https://github.com/oviliz the resize part is sort of an unfinished
feature. I totally forgot about it.

youu can resize the images but in the css file still the width and height
of the box are still 40px.

I'll see what I can do in the next version.

As for the color name after the label...I will try to do that but it's not
very high priority.


Reply to this email directly or view it on GitHub
#87 (comment).

@oviliz
Copy link

oviliz commented Jan 1, 2015

PS. La multi ani! :)
On 1 Jan 2015 13:10, "Cristian O. Balan" ovidio.balan@gmail.com wrote:

I'm sure that I've done that via CSS.
The "...50px!important" should help.
On 1 Jan 2015 10:38, "Marius Strajeru" notifications@github.com wrote:

@Jerry-Yocupco https://github.com/Jerry-Yocupco @oviliz
https://github.com/oviliz the resize part is sort of an unfinished
feature. I totally forgot about it.

youu can resize the images but in the css file still the width and height
of the box are still 40px.

I'll see what I can do in the next version.

As for the color name after the label...I will try to do that but it's
not very high priority.


Reply to this email directly or view it on GitHub
#87 (comment).

@Jerry-Yocupco
Copy link
Author

@tzyganu Thanks for the update, I will look forward to it

@tzyganu
Copy link
Owner

tzyganu commented Mar 23, 2015

@Jerry-Yocupco Sorry for the late response. This bug should be fixed in version 2.2.0

@tzyganu tzyganu closed this as completed Mar 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants