boot: cancelable kernel loads #1698
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugelgupf
force-pushed
the
lazy-files
branch
3 times, most recently
from
6b0ef14
to
9e5a202
Compare
hugelgupf
force-pushed
the
lazy-files
branch
2 times, most recently
from
ac21738
to
9cb2938
Compare
hugelgupf
force-pushed
the
lazy-files
branch
2 times, most recently
from
4c43d9b
to
bb006f4
Compare
|
I just added the ability to interrupt a kernel from being downloaded if it's already been chosen in the boot menu. So you can do something like choose option 1, but still cancel it as long as the actual kexec hasn't happened yet. Useful if the download is taking a long time and you want to explore other options (or drop to shell and debug why it's taking so long). |
Signed-off-by: Chris Koch <chrisko@google.com>
We'll be able to test interruptions with this. Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
hugelgupf
changed the title
|
do we still want this? It seems useful? |
rminnich
added
the
Awaiting author
|
Cleaning out PRs > 1yo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements Option 1 from #1672.
Despite me liking that option less when I wrote #1672, I had started working on version 2 as well, and it involved basically a second copy of every structure we have in pkg/boot and weird translations between them.
Putting this out as an RFC.