Fix zipslips for cpio, tar and zip #2344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the following CVEs: * CVE-2020-7669 * CVE-2020-7666 * CVE-2020-7665 A zipslip is when a archive contains a path which escapes the extract directory. This can be done with absolute paths `/` or with parent directories `..`. It is a security problem. These commands will no longer extract those directories and instead print a warning. Signed-off-by: Ryan O'Leary <ryanoleary@google.com>
ChriMarMe
approved these changes
Mar 9, 2022
Codecov Report
@@ Coverage Diff @@
## main #2344 +/- ##
=======================================
Coverage 72.18% 72.19%
=======================================
Files 386 387 +1
Lines 39843 39859 +16
=======================================
+ Hits 28762 28775 +13
- Misses 11081 11084 +3
Continue to review full report at Codecov.
|
Closed
|
The remediation falsely prohibits a file such as "...tmp", does it not? TODO(ehg) Someday I should confirm there is no related issue with symbolic links. |
|
See also nativeRelPath in golang.org/x/build/cmd/buildlet/buildlet.go, i.e. relPath == ".." || strings.HasPrefix(relPath, ".."+string(filepath.Separator) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following CVEs:
A zipslip is when a archive contains a path which escapes the extract
directory. This can be done with absolute paths
/or with parentdirectories
... It is a security problem.These commands will no longer extract those directories and instead
print a warning.
Signed-off-by: Ryan O'Leary ryanoleary@google.com