Remove the dependency on un-idiomatic Go strings for IPMI blobs. #2640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2640 +/- ##
==========================================
+ Coverage 74.93% 75.09% +0.16%
==========================================
Files 413 413
Lines 41661 41661
==========================================
+ Hits 31217 31285 +68
+ Misses 10444 10376 -68 see 5 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
brandonkimbk
previously approved these changes
Mar 22, 2023
10000TB
reviewed
Mar 23, 2023
In u-root#2622, the u-root IPMI blob library was fixed to stop requiring blob IDs to contain trailing NUL characters in them (which is unidiomatic). As a backwards-compatibility step, the library still accepts blob IDs with the trailing NUL, but the library did stop providing blob ID strings (in BlobEnumerate) with these trailing NULs. The smbios transfer utility had a hard dependency on this trailing NUL (in the equality check). This change fixes that in a way that still supports old versions of u-root if needed, by using strings.TrimSuffix. Signed-off-by: Chris Fenner <cfenn@google.com>
hugelgupf
reviewed
Mar 23, 2023
10000TB
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2622, the u-root IPMI blob library was fixed to stop requiring blob IDs to contain trailing NUL characters in them (which is unidiomatic). As a backwards-compatibility step, the library still accepts blob IDs with the trailing NUL, but the library did stop providing blob ID strings (in BlobEnumerate) with these trailing NULs.
The smbios transfer utility had a hard dependency on this trailing NUL (in the equality check). This change fixes that in a way that still supports old versions of u-root if needed, by using strings.TrimSuffix.