Fix dmesg test so that testtool works in CI #2809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Container environments are not always truthful about the UID. Sometimes UID 0 in a container can not do root-level operations. Also, use errors.Is instead of comparing strings; embed returned errors with %w for testing. Signed-off-by: Ronald G Minnich <rminnich@gmail.com>
10000TB
approved these changes
Nov 22, 2023
rminnich
added
automerge
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2809 +/- ##
==========================================
+ Coverage 75.14% 75.30% +0.15%
==========================================
Files 432 432
Lines 42936 42936
==========================================
+ Hits 32266 32334 +68
+ Misses 10670 10602 -68 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Container environments are not always truthful about the UID. Sometimes UID 0 in a container can not do root-level operations.
Also, use errors.Is instead of comparing strings;
embed returned errors with %w for testing.