Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gosh default shell #2904

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Make gosh default shell #2904

merged 1 commit into from
Feb 7, 2024

Conversation

hugelgupf
Copy link
Member

Here's my suggestion:

  • we make gosh default shell
  • we release v0.14.0
  • we wait to see if anybody has complaints
  • In v0.15.0 we can delete elvish

Signed-off-by: Chris Koch <chrisko@google.com>
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ec02d47) 77.67% compared to head (87cfba0) 77.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2904      +/-   ##
==========================================
- Coverage   77.67%   77.53%   -0.15%     
==========================================
  Files         419      419              
  Lines       42795    42795              
==========================================
- Hits        33242    33182      -60     
- Misses       9553     9613      +60     
Flag Coverage Δ
.-amd64 67.87% <100.00%> (ø)
cmds/...-amd64 71.40% <ø> (+0.01%) ⬆️
integration/generic-tests/...-amd64 18.16% <ø> (ø)
integration/generic-tests/...-arm 0.00% <ø> (ø)
integration/generic-tests/...-arm64 21.61% <ø> (ø)
integration/gotests/...-amd64 74.66% <ø> (-0.19%) ⬇️
integration/gotests/...-arm 76.01% <ø> (-0.01%) ⬇️
integration/gotests/...-arm64 75.98% <ø> (+0.07%) ⬆️
pkg/...-amd64 76.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hugelgupf hugelgupf added the Awaiting reviewer Waiting for a reviewer. label Feb 7, 2024
Copy link
Member

@rminnich rminnich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it. Yes, release with rush, then release with elvish deleted. That's great.

@hugelgupf hugelgupf merged commit 3ee8b39 into u-root:main Feb 7, 2024
26 checks passed
@hugelgupf hugelgupf deleted the gosh-default branch February 7, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting reviewer Waiting for a reviewer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants