Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command brctl #2971

Merged
merged 34 commits into from
Jun 14, 2024
Merged

Add command brctl #2971

merged 34 commits into from
Jun 14, 2024

Conversation

leongross
Copy link
Contributor

@leongross leongross commented Apr 25, 2024

Add cmd/brctl which aims to be a (near) feature complete implementation of brctl.

TODOs

  • Enhance test coverage
    • add vmtest
  • minifiy str_to_jiffies
  • getBridge interface parsing
  • Setgcint command
  • get interfaces from bridges
  • improve documentation

@10000TB 10000TB self-assigned this Apr 25, 2024
@10000TB 10000TB requested a review from a team April 25, 2024 16:48
@rminnich
Copy link
Member

nice! This is going to be very useful.

@rminnich rminnich added the Awaiting author Waiting for new changes or feedback for author. label Apr 25, 2024
cmds/core/brctl/brctl.go Outdated Show resolved Hide resolved
@leongross leongross force-pushed the cmds/brctl branch 7 times, most recently from 4a4d9bf to b30fce5 Compare April 26, 2024 16:17
cmds/core/brctl/brctl.go Outdated Show resolved Hide resolved
@10000TB
Copy link
Member

10000TB commented Apr 30, 2024

Edit: NVM -- discussed offline, I mis-understood the github UI. I was told this PR was opened from a fork of u-root.


@leongross Hi Leon, looks like this Draft is pushed against upstream u-root

leongross wants to merge 13 commits into u-root:main from leongross:cmds/brctl

Could you push against a fork of u-root, and make this as a PR ?

This looks like review-worthy.

@leongross
Copy link
Contributor Author

leongross commented Apr 30, 2024

@10000TB I'm not quite sure what kind of review process you suggest.
My PR goes from my private fork to the upstream u-root. What benefit is there to create a PR for another fork or even my own? There still needs to be a PR for upstream u-root after all, so why create another layer?
As I see it the procedure of this PR adheres to CONTRIBUTING.md guide. Maybe I misunderstood your suggestion, so I'd be glad if you could clarify.

@leongross leongross marked this pull request as ready for review April 30, 2024 09:41
cmds/core/brctl/brctl.go Outdated Show resolved Hide resolved
@10000TB
Copy link
Member

10000TB commented May 2, 2024

@10000TB I'm not quite sure what kind of review process you suggest. My PR goes from my private fork to the upstream u-root. What benefit is there to create a PR for another fork or even my own? There still needs to be a PR for upstream u-root after all, so why create another layer? As I see it the procedure of this PR adheres to CONTRIBUTING.md guide. Maybe I misunderstood your suggestion, so I'd be glad if you could clarify.

you good. I mis-understood the github UI ;)

@leongross leongross force-pushed the cmds/brctl branch 4 times, most recently from 2a9acf3 to 032a98a Compare May 3, 2024 09:44
@leongross leongross force-pushed the cmds/brctl branch 4 times, most recently from 3d8137e to 3772a48 Compare May 15, 2024 18:43
@10000TB 10000TB added Awaiting author Waiting for new changes or feedback for author. and removed Awaiting reviewer Waiting for a reviewer. labels Jun 14, 2024
Signed-off-by: Christopher Meis <christopher.meis@9elements.com>
pkg/brctl/brctl.go Outdated Show resolved Hide resolved
pkg/brctl/brctl.go Outdated Show resolved Hide resolved
pkg/brctl/brctl.go Outdated Show resolved Hide resolved
pkg/brctl/brctl.go Outdated Show resolved Hide resolved
pkg/brctl/brctl.go Outdated Show resolved Hide resolved
pkg/brctl/brctl.go Outdated Show resolved Hide resolved
pkg/brctl/brctl.go Outdated Show resolved Hide resolved
pkg/brctl/brctl.go Outdated Show resolved Hide resolved
pkg/brctl/brctl.go Outdated Show resolved Hide resolved
pkg/brctl/brctl.go Outdated Show resolved Hide resolved
pkg/brctl/brctl.go Outdated Show resolved Hide resolved
pkg/brctl/brctl.go Outdated Show resolved Hide resolved
pkg/brctl/brctl.go Outdated Show resolved Hide resolved
pkg/brctl/brctl.go Outdated Show resolved Hide resolved
pkg/brctl/brctl.go Outdated Show resolved Hide resolved
pkg/brctl/brctl.go Outdated Show resolved Hide resolved
pkg/brctl/util.go Outdated Show resolved Hide resolved
pkg/brctl/util.go Outdated Show resolved Hide resolved
pkg/brctl/util.go Outdated Show resolved Hide resolved
@binjip978
Copy link
Contributor

Added some comments about naming from this guideline https://google.github.io/styleguide/go/decisions#underscores, but maybe I missed something.

pkg/brctl/brctl.go Outdated Show resolved Hide resolved
Signed-off-by: leongross <leon.gross@9elements.com>
@10000TB 10000TB merged commit b367317 into u-root:main Jun 14, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting author Waiting for new changes or feedback for author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants