Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manually adding media is broken #421

Closed
goto-bus-stop opened this issue Feb 10, 2021 · 0 comments · Fixed by #422 or Mrcl1450/core#1
Closed

Manually adding media is broken #421

goto-bus-stop opened this issue Feb 10, 2021 · 0 comments · Fixed by #422 or Mrcl1450/core#1
Labels
bug

Comments

@goto-bus-stop
Copy link
Member

goto-bus-stop commented Feb 10, 2021 •
edited
Loading

Only imports still work.

#416 is causing POST /playlists/:id/media to reject valid requests.

This should accept an object with playlist item properties, not a bare ObjectID:

core/src/validations.js

Lines 333 to 336 in 9cb81a5

items: {
type: 'array',
items: { $ref: 'https://ns.u-wave.net/schemas/definitions.json#/definitions/ObjectID' },
},

goto-bus-stop added a commit that referenced this issue Feb 10, 2021
@goto-bus-stop
Fix validation when adding media to a playlist
6695098 
Fixes #421
@goto-bus-stop goto-bus-stop mentioned this issue Feb 10, 2021
Merged
goto-bus-stop added a commit that referenced this issue Feb 10, 2021
@goto-bus-stop
Fix validation when adding media to a playlist
42feb86 
Fixes #421
@Mrcl1450 Mrcl1450 mentioned this issue Feb 10, 2021
Merged
goto-bus-stop added a commit that referenced this issue Feb 10, 2021
@goto-bus-stop
Fix validation when adding media to a playlist (#422)
0e19b1d 
Fixes #421
@goto-bus-stop goto-bus-stop mentioned this issue Feb 10, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
1 participant
@goto-bus-stop