New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add waitlist lock and cycle settings #519

Merged

goto-bus-stop merged 30 commits into default from disable-cycle

Oct 28, 2022

Member

goto-bus-stop commented May 21, 2022 •

edited

Loading

Adds a waitlist settings section and makes auto-cycling optional, closing #89.

Todo:

add tests for the waitlist and booth

goto-bus-stop added 4 commits

May 20, 2022 22:59


          Move waitlist lock state to a setting

6603f6a


          emit waitlist:lock in response to setting change

f285206


          Add option to disable waitlist cycling, closes #89

6fe1a9b


          fixes

74ee6da

coveralls commented May 21, 2022 •

edited

Loading

Coverage increased (+1.9%) to 80.161% when pulling 6694e1b on disable-cycle into 73c862d on default.

goto-bus-stop added 5 commits

May 21, 2022 09:35


          Do not modify the options object

b187e36


          flaky tests...

ea71362


          booth: make private methods private


          waitlist: make private methods private

5caba64


          Use redis scripts for atomic waitlist ops

ec2896e

This comment was marked as resolved.

Sign in to view

goto-bus-stop added 2 commits

May 21, 2022 15:19


          tweaks

c084697


          waitlist.add overrules waitlist.join.locked

0284c00

This comment was marked as resolved.

Sign in to view


          tweaks

d2b814a

This comment was marked as resolved.

Sign in to view


          ts-expect-error

5bc0acf

This comment was marked as resolved.

Sign in to view


          Merge branch 'default' into disable-cycle

64f51d9

This comment was marked as resolved.

Sign in to view

goto-bus-stop added 2 commits

May 31, 2022 19:09


          Remove obsolete code from SocketServer


          Use nodeback-style {err, value} return values for lua scripts

bb98e3b

This comment was marked as duplicate.

Sign in to view

goto-bus-stop added 4 commits

June 1, 2022 14:58


          Use error code constants

fc07b90


          Emit config update events over Redis

c5d16fb


          Merge branch 'no-local-emission' into disable-cycle

9620aff


          Use the config subscribe mechanism

d0184ed

This comment was marked as duplicate.

Sign in to view


          Wait for config to propagate

35f2765

This comment was marked as duplicate.

Sign in to view

goto-bus-stop added 3 commits

June 5, 2022 12:42


          Close sockets more cleanly

3a38d5d


          Use redis scripting builtin error features

d701c41


          Use auto-extending redlock.using() for advance locking

9f8b253

This comment was marked as duplicate.

Sign in to view


          Clean up debounced guest counting when closing WebSocket server

8217ae0

This comment was marked as duplicate.

Sign in to view


          Merge branch 'default' into disable-cycle

256f0cc

This comment was marked as duplicate.

Sign in to view


          Merge branch 'default' into disable-cycle

62f0b0d

This comment was marked as duplicate.

Sign in to view

goto-bus-stop changed the title ~~Move waitlist lock state to a setting~~ Add waitlist lock and cycle settings

goto-bus-stop added 2 commits

October 28, 2022 13:51


          Merge branch 'default' into disable-cycle

47a8f52


          remove unused import

cb221ed

goto-bus-stop force-pushed the disable-cycle branch from 3dce51d to cb221ed Compare

October 28, 2022 11:52


          fix type

6694e1b

goto-bus-stop merged commit 190469c into default

goto-bus-stop deleted the disable-cycle branch

October 28, 2022 12:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment