Do not rely on in-process event emitters #522
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configuration system is still a bit halfbaked, but one of its problems is that it relies on a simple EventEmitter to notify the server about configuration changes. I still kinda want this to be able to run in multiple processes eventually (eg. rest api + websocket as separate processes), this would be one requirement to get to that situation.
Also removing some obsolete stuff from the HttpApi implementation … may need to re-add it if we dooo end up with the ability to run rest and WS separately but for now it does nothing.