Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pinterest.com: ads #16721

Closed
8 of 9 tasks
basilwizard opened this issue Feb 12, 2023 · 10 comments
Closed
8 of 9 tasks

pinterest.com: ads #16721

basilwizard opened this issue Feb 12, 2023 · 10 comments

Comments

@basilwizard
Copy link

basilwizard commented Feb 12, 2023

Prerequisites

  • I read and understand the policy about what is a valid filter issue.
  • I verified that this issue is not a duplicate. (Use this button to find out.)
  • I forced an update of my filter lists. (Click the "Purge all caches" button while holding the 'Shift' key, then click the "Update now" button.)
  • I did not remove any of the default filter lists, or I have verified that the issue was not caused by removing any of the default lists.
  • I did not enable external filter lists, or I have verified that the issue still occurs without enabling external filter lists.
  • I do not have custom filters/rules, or I have verified that the issue still occurs without custom filters/rules.
  • I am not using uBlock Origin (uBO) along with other similarly-purposed blockers.
  • I have verified that the web browser's built-in blocker or DNS blocking (standalone or through a VPN) is not causing the issue.
  • I did not answer truthfully to ALL the above checkpoints.

URL address of the web page

https://www.pinterest.com/

Category

ads

Description

All ads on pinterest are no longer being blocked. says 0% of ads being blocked. 8 out of 10 domains connected.

Screenshot(s)

Screenshot(s)

Configuration

uBlock Origin: 1.46.0
Firefox: 109
filterset (summary): 
  network: 83111
  cosmetic: 38477
  scriptlet: 16944
  html: 887
listset (total-discarded, last-updated): 
  default: 
    user-filters: 0-0, never
    ublock-filters: 32786-65, 14h.56m
    ublock-badware: 4302-5, 14h.55m
    ublock-privacy: 307-0, 11d.22h.41m
    ublock-abuse: 77-0, 11d.17h.56m
    ublock-unbreak: 1890-2, 14h.54m
    ublock-quick-fixes: 450-0, 5m
    easylist: 61276-633, 3d.13h.44m
    easyprivacy: 30933-1740, 3d.13h.43m
    urlhaus-1: 6351-0, 4m
    plowe-0: 3670-2, 10d.14h.35m
filterset (user): [empty]
trustedset: 
  added: [array of 1 redacted]
modifiedUserSettings: [none]
modifiedHiddenSettings: [none]
supportStats: 
  allReadyAfter: 676 ms (selfie)
  maxAssetCacheWait: 119 ms
popupPanel: 
  blocked: 3
  blockedDetails: 
    pinterest.com: 1
    cedexis.com: 1
    googletagmanager.com: 1
@mapx-
Copy link
Contributor

mapx- commented Feb 12, 2023

You have to be specific especially with sites like pinterest: specific pages, screenshot where we could see the ads etc

@basilwizard
Copy link
Author

basilwizard commented Feb 12, 2023

@mapx-
Copy link
Contributor

mapx- commented Feb 12, 2023

The promoted items are already hidden by this filter in Easylist:

pinterest.com##div[data-test-id="pin"]> *:has-text(Promoted by)

You should reset uBO to default settings, update all lists and test again

@basilwizard
Copy link
Author

Ok, I rest uBO to default, updated all the lists and the promoted ads are still there

@mapx-
Copy link
Contributor

mapx- commented Feb 12, 2023

There is only a delay on my side: scrolling down the promoted stuff appears for a second then it's hidden

@garry-ut99
Copy link
Contributor

Maybe another hard to reproduce case, like before: #10803

@mapx-
Copy link
Contributor

mapx- commented Feb 12, 2023

@basilwizard test this filter

pinterest.*##:xpath('//*[contains(text(),"Promoted")]'):upward([data-grid-item])

@basilwizard
Copy link
Author

omg that worked thank you!

@Yuki2718
Copy link
Contributor

I wonder why the current rules are not working (working fine on my end). @basilwizard Can you disable the current rule by adding pinterest.*#@#:xpath('//*[contains(text(),"Promoted")]'):upward([data-grid-item]) and take screenshots of DOM of the ads like #10803 (comment)? Right-click on the ad and choose "Inspect element".

@Yuki2718
Copy link
Contributor

Still unable to reproduce, not only the EL rule but also pinterest.*##div[data-test-id="pin"] span:not([class]):has-text(/Promoted by|広告/):upward([data-grid-item="true"]) is covering exactly the same and thus redundant. I'll merge them.

Yuki2718 added a commit that referenced this issue Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants