Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pinterest.co.uk: ads #10803

Closed
6 tasks done
MrHappymoose opened this issue Dec 7, 2021 · 59 comments
Closed
6 tasks done

pinterest.co.uk: ads #10803

MrHappymoose opened this issue Dec 7, 2021 · 59 comments

Comments

@MrHappymoose
Copy link

Prerequisites

URL address of the web page

https://www.pinterest.co.uk/

Category

ads

Describe the issue

Over the last few months previously blocked 'Promoted Pins' have been showing as blank spaces on the page rather than all real pins shifting together properly. I suppose something like a week to ten days ago (Approximately) the 'Promoted Pins' have started showing completely as if not being blocked at all, this includes autorunning video clips in pins.

Screenshot(s)

Screenshot(s)

Configuration

uBlock Origin: 1.39.2
Chromium: 96
filterset (summary): 
  network: 78443
  cosmetic: 39426
  scriptlet: 16264
  html: 0
listset (total-discarded, last updated): 
  default: 
    easylist: 61345-6, 1m
    easyprivacy: 26463-17, 1m
    plowe-0: 3698-811, 1m
    ublock-abuse: 72-0, 1m
    ublock-badware: 3539-60, 1m
    ublock-filters: 29881-127, 1m
    ublock-privacy: 188-1, 1m
    ublock-unbreak: 1705-38, 1m
    urlhaus-1: 8444-0, 1m
filterset (user): [array of 1 redacted]
trustedset: 
  added: [array of 3 redacted]
modifiedUserSettings: [none]
modifiedHiddenSettings: [none]
supportStats: 
  launchToReadiness: 27090
  launchFromSelfie: true
popupPanel: 
  blocked: 4
@gorhill

This comment has been minimized.

@MrHappymoose

This comment has been minimized.

@gorhill

This comment has been minimized.

@MrHappymoose

This comment has been minimized.

@gwarser

This comment has been minimized.

@gorhill

This comment has been minimized.

@gorhill

This comment has been minimized.

@MrHappymoose

This comment has been minimized.

@mapx-
Copy link
Contributor

mapx- commented Dec 9, 2021

@MrHappymoose provide screenshot, specific page, indications on the ads

@MrHappymoose
Copy link
Author

Not entirely sure why this has been closed as I wasn't exactly given a lot of time to respond. Is it even worth me bothering to provide the screenshots now??

@mapx- mapx- reopened this Dec 10, 2021
@mapx-
Copy link
Contributor

mapx- commented Dec 10, 2021

provide the info (screenshot, specific page, indications on the ads)

@MrHappymoose
Copy link
Author

example 01
example 02
example 03

Example 01 - https://www.pinterest.co.uk/pin/727049933586892218/

Example 02 - https://www.pinterest.co.uk/pin/844493665938055/

Example 03 - https://www.pinterest.co.uk/

As you can see the adverts that were previously blocked now appear on multiple pages

@mapx-
Copy link
Contributor

mapx- commented Dec 10, 2021

All fine on my side, the promoted by are still hidden by:

pinterest.co.uk##div[data-test-id="pin"]:has(div[title="Promoted by"])

@mapx-
Copy link
Contributor

mapx- commented Dec 10, 2021

You should reset uBO to default settings, then force an update of all lists.
Don't use other extensions while testing again.

@MrHappymoose
Copy link
Author

You should reset uBO to default settings, then force an update of all lists. Don't use other extensions while testing again.

I just set up a fresh instance of Chrome with uBO being the only app even installed and I still got the ads. I also checked Firefox with just uBO and still have the same issue

@gorhill
Copy link
Member

gorhill commented Dec 11, 2021

I don't have an account on that site, I see that even with uBO disabled I do not see such ads as seen in your screenshots.

@mapx-
Copy link
Contributor

mapx- commented Dec 11, 2021

I have an account and the existent filters are still working fine.

@gorhill gorhill mentioned this issue Dec 11, 2021
6 tasks
@gorhill
Copy link
Member

gorhill commented Dec 11, 2021

It would be useful to see the HTML layout of those ads in the browser inspector.


Can you right-click on the "Promoted ads" label and select "Inspect" and post a screenshot of what it shows?

@amuhav
Copy link

amuhav commented Dec 11, 2021

sorry, the button to check if anything had already been logged didn't show any open issues as I'm using .com rather than .co.uk. Would like to add that for some reason, some accounts do not seem to get ads and we don't know why. I have two other friends that use the site, both with ordinary accounts, and one never gets any ads even with all adblockers off.

@amuhav
Copy link

amuhav commented Dec 11, 2021

image
wasn't sure how much to screenshot

@Yuki2718
Copy link
Contributor

Test pinterest.*##.Hsu.iyn.zI7 > div[style^="-webkit-line-clamp"] > span:has-text(Promoted by):upward(2)

@amuhav
Copy link

amuhav commented Dec 11, 2021

that just removes the "Promoted by" label, not the ad.

@Yuki2718
Copy link
Contributor

How about pinterest.*##.Hsu.iyn.zI7 > div[style^="-webkit-line-clamp"] > span:has-text(Promoted by):upward(a[tabindex]):upward(2) There may be better way, but anyway.

@gorhill
Copy link
Member

gorhill commented Dec 11, 2021

I don't think it's catching anything other than ads, but hard to tell when you can't replicate the exact same page with a refresh.

You can use uBO's own DOM inspector to reveal what was hidden by the cosmetic filter.

@amuhav
Copy link

amuhav commented Dec 11, 2021

image

unfortunately not!

@gorhill
Copy link
Member

gorhill commented Dec 11, 2021

@Yuki2718 Why stop at div[data-test-id="pin"]? On my side I can go up to [data-grid-item="true"].

Can you guys try:

pinterest.*##span:not([class]):has-text(Promoted by):upward([data-grid-item="true"])

@Yuki2718
Copy link
Contributor

Hiding won't work so pinterest.*##span:not([class]):has-text(Promoted by):upward([data-grid-item="true"]):remove()

@gorhill
Copy link
Member

gorhill commented Dec 11, 2021

Hiding won't work

Right, the page positions the items with absolute x,y values. uBO's DOM inspector won't show removed items so there is no point using it then.

@gorhill
Copy link
Member

gorhill commented Dec 11, 2021

Just to be reduce likelihood of false positives, we can use data-test-id to narrow down, so maybe final version:

pinterest.*##div[data-test-id="pin"] span:not([class]):has-text(Promoted by):upward([data-grid-item="true"]):remove()

@amuhav
Copy link

amuhav commented Dec 11, 2021

that one broke the page when trying to scroll down...

@amuhav
Copy link

amuhav commented Dec 11, 2021

the last one to work and not break everything when scrolling was

pinterest.*##.Hsu.iyn.zI7 > div[style^="-webkit-line-clamp"] > span:has-text(Promoted by):upward(div[data-test-id="pin"]):remove()

@Yuki2718
Copy link
Contributor

I can reproduce (I don't see ads so with an alternative rule), if removed page breaks

@Yuki2718
Copy link
Contributor

pinterest.*##div[data-test-id="pin"] span:not([class]):has-text(Promoted by):upward([data-grid-item="true"]) should work tho leaves the space.

@gorhill
Copy link
Member

gorhill commented Dec 11, 2021

So maybe data-grid-item should not be removed after all. Can you try:

pinterest.*##div[data-test-id="pin"] span:not([class]):has-text(Promoted by):upward([data-test-id="pin"]):remove()

I just like that it does not rely on random-looking class names.

@Yuki2718
Copy link
Contributor

@gorhill He already tried that and that can't remove the space, as expected.

@gorhill
Copy link
Member

gorhill commented Dec 11, 2021

He said similar worked above. I just use a different selector before :has-text(Promoted by):upward([data-test-id="pin"]):remove().

@Yuki2718
Copy link
Contributor

He meant it doesn't break but leaves space, if I understand correctly.

@Yuki2718
Copy link
Contributor

Probably pinterest.*##div[data-test-id="pin"] span:not([class]):has-text(Promoted by):upward([data-grid-item="true"]) is the best we can, as scriptlet can't be used.

@amuhav
Copy link

amuhav commented Dec 11, 2021

I'm getting confused 😅

The ones I said "broke the page" literally broke the page when scrolling, the pins part of the page completely disappears.

Otherwise, every other one worked exactly the same, got rid of the ad pins leaving a white space. Takes a split second to hide them though, which I don't think it was doing before whatever ublock was doing originally stopped working, but suspect that's the best that can be hoped for? Still better than seeing them permanently.

@Yuki2718
Copy link
Contributor

Yep, at least I can't do anything better. Thanks for your cooperation.

@amuhav
Copy link

amuhav commented Dec 11, 2021

thank you, the site is at least more bearable now!

@mapx-
Copy link
Contributor

mapx- commented Dec 11, 2021

@MrHappymoose are you using some pinterest extension ? I'm seeing in your screenshot "data pinterest extension installed"

@MrHappymoose
Copy link
Author

@MrHappymoose are you using some pinterest extension ? I'm seeing in your screenshot "data pinterest extension installed"

I do have the Pinterest Add Button app installed. Could do with out it to be honest, it rarely works anyway.

@mapx-
Copy link
Contributor

mapx- commented Dec 11, 2021

The question is: did you test without having that extension enabled ?

@MrHappymoose
Copy link
Author

The question is: did you test without having that extension enabled ?

As I said previously

#10803 (comment)

I just set up a fresh instance of Chrome with uBO being the only app even installed and I still got the ads. I also checked Firefox with just uBO and still have the same issue

@MrHappymoose
Copy link
Author

Okay, now I'm somewhat confused as it appears that this has been closed again. I realise that there was some coding stuff going on but honestly, I'm not a coder so is there a fix for this that I should be implementing at my end as nothing has changed for me.

@mapx-
Copy link
Contributor

mapx- commented Dec 12, 2021

@MrHappymoose You could save your page => you'll get a html page + a folder, zip them together and upload the zip on some server, then put here the link

@gorhill
Copy link
Member

gorhill commented Dec 12, 2021

is there a fix for this

The fix was added yesterday. Did you force an update of "uBlock filters" then reload the pinterest page?

@MrHappymoose
Copy link
Author

is there a fix for this

The fix was added yesterday. Did you force an update of "uBlock filters" then reload the pinterest page?

Just done that and back to the blank spaces where ads are. This is infinitely preferable to all those videos auto playing. Many thanks for the fix and for your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants