Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

walla.co.il - video ads #1787

Closed
IsraeliUser opened this issue Mar 25, 2018 · 15 comments
Closed

walla.co.il - video ads #1787

IsraeliUser opened this issue Mar 25, 2018 · 15 comments

Comments

@IsraeliUser
Copy link

Default Settings + EasyList Hebrew
We only managed to hide the video ads - audio is still being played.
Do you have any idea how to fix it?

@mapx-
Copy link
Contributor

mapx- commented Mar 25, 2018

an example of such page /video ?

@IsraeliAdblocker
Copy link

https://news.walla.co.il/item/3145435

New WebRTC.

$webrtc isn't working.

@mapx-
Copy link
Contributor

mapx- commented Mar 26, 2018

No issue for me - the video is running fine (probably the video ads are pushed only for ISR IPs)

@IsraeliAdblocker
Copy link

It's true, you can use a VPN like hola or something. can you see the webRTC connection under chrome://webrtc-internals?

@uBlock-user
Copy link
Contributor

$webrtc isn't working.

$webrtc doesn't exist for uBlock Origin.

@mapx-
Copy link
Contributor

mapx- commented Mar 26, 2018

Hola VPN does not open websites from Israel

@okiehsch
Copy link
Contributor

you see the webRTC connection under chrome://webrtc-internals?

Yes,
unbenannt

but I do not get any video ads.

@okiehsch
Copy link
Contributor

I can disable all webRTC connections on my end by adding
walla.co.il##script:inject(abort-on-property-read.js, TextDecoder)
no clue if this solves your issue, or if this breaks some site functionality.

@IsraeliAdblocker
Copy link

IsraeliAdblocker commented Mar 27, 2018

@okiehsch working like a charm
can you add it to the uBlock filters?
also the same filter for this site: inn.co.il

@smed79
Copy link
Contributor

smed79 commented Mar 27, 2018

can you add it to the uBlock filters?

MajkiIT/polish-ads-filter#4898

@mapx-
Copy link
Contributor

mapx- commented Mar 27, 2018

yeah, it would be better maintaining your own specific uBo filters @IsraeliUser

@IsraeliUser
Copy link
Author

I don't think it's necessary at this point.
We do have some uBO-specific filters in our list ($redirect, $important).
We don't use script:inject filters because issues with other adblockers.
Please add this filter to uBO's filters.

@mapx- mapx- closed this as completed in 3d22fa8 Mar 27, 2018
okiehsch added a commit that referenced this issue Mar 27, 2018
@IsraeliUser
Copy link
Author

Ads are back.
Please add:
walla.co.il##script:inject(abort-current-inline-script.js, btoa, upManager)
walla.co.il##script:inject(abort-current-inline-script.js, atob, TextDecoder)

@IsraeliUser
Copy link
Author

@okiehsch @mapx-

@okiehsch
Copy link
Contributor

okiehsch commented Apr 1, 2018

What is the issue exactly, if it is still the webRTC connection then I fail to see how your proposed filters

walla.co.il##script:inject(abort-current-inline-script.js, btoa, upManager)
walla.co.il##script:inject(abort-current-inline-script.js, atob, TextDecoder)

can fix that.

After I add your filters:
unbenannt

I can prevent that webRTC connection, without breaking the video player, by adding
@@||broomhilda.eu-west-1.elasticbeanstalk.com^$xmlhttprequest,domain=walla.co.il

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants