Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bloomberg.com #463

Closed
gotitbro opened this issue Jun 18, 2017 · 23 comments
Closed

bloomberg.com #463

gotitbro opened this issue Jun 18, 2017 · 23 comments

Comments

@gotitbro
Copy link

The navigation menu appears under the tabs on pages instead of appearing over them.

Screen Capture: https://streamable.com/y70xa
Error URL: https://www.bloomberg.com/research/stocks/private/snapshot.asp?privcapId=242837958

Note: Using uBO 1.12.4 on Chrome 59 with the default filters and settings.

@gotitbro
Copy link
Author

The issue also exists without a blocker.

It does not actually, when adb is turned off the space below the navigation menu is taken by an ad and when the navigation menu is browsed it does come over the ad: https://streamable.com/32sm4

The filter works. Also similar issue with the search bar, it comes under the tabs as well: http://i.imgur.com/T8fEVkz.png


It takes some time before the elements are hidden on company profile pages.

Screen Capture: https://streamable.com/0ct0o
Error URL: https://www.bloomberg.com/profiles/companies/1041347D:LN-captify-media-ltd

@gotitbro
Copy link
Author

Also similar issue with the search bar, it comes under the tabs as well: http://i.imgur.com/T8fEVkz.png

This is also fixed by a similar filter as the one suggested above:
bloomberg.com##.bb-search-drawer:style(z-index: 1000 !important;)

@gorhill Please see what can be done for the issue of the late hiding elements above.

@gotitbro
Copy link
Author

gotitbro commented Jun 19, 2017

@gorhill Just realized that the elements being hidden late is not due to cosmetic filters. These are automatically hidden when no ad loads in them by an inline script on the page.

One way to solve this is hiding the ad elements through the blocker itself:
bloomberg.com##.partner_module

@okiehsch
Copy link
Contributor

I am obviously missing one or more deleted comments here, so @gotitbro is your issue fixed if you add

bloomberg.com##.bb-nav-categories:style(z-index: 1000 !important;)
bloomberg.com##.bb-nav-search:style(z-index: 1000 !important;)

@gotitbro
Copy link
Author

I am obviously missing one or more deleted comments here

@okiehsch The initial filter was suggested by @gorhill not sure why he deleted his comment. And yes my issue is fixed by these filters.

@gotitbro
Copy link
Author

@okiehsch @gorhill The filters above cause a problem wherein the functions of the stickied header become unusable (which also contains the share buttons).

Screencapture: https://streamable.com/d07vu

Error URL:
https://www.bloomberg.com/news/articles/2017-07-31/venezuela-s-president-maduro-personally-sanctioned-by-the-u-s

@gotitbro
Copy link
Author

gotitbro commented Nov 18, 2017

@okiehsch The stock list below the header is blocked on stock quote pages on https://www.bloomberg.com. It loads fine when uBO is disabled.

SS: https://i.imgur.com/6GluN94.png (SS of the item getting blocked, marked)
Error URL: https://www.bloomberg.com/quote/FAST:US

Note: Using uBO 1.14.18 on Chrome 62 with the default filters and settings.

@mapx-
Copy link
Contributor

mapx- commented Nov 21, 2017

bloomberg.com#@#.page-ad
@@||securepubads.g.doubleclick.net^$script,domain=bloomberg.com
@@||googletagservices.com/tag/js/gpt.js$script,domain=bloomberg.com

last one necessary to set OFF the filter from ublock privacy

@gorhill is this normal that redirect filter (last one from ublock privacy) gives no info about its redirecting in the logger ?

@gorhill
Copy link
Member

gorhill commented Nov 21, 2017

@mapx-

is this normal that redirect filter (last one from ublock privacy) gives no info about its redirecting in the logger ?

I see the redirection on my side (without the exception filter of course).

@mapx-
Copy link
Contributor

mapx- commented Nov 21, 2017

@gorhill , right ... (first I have selected all "--" , so the redirect wasn't there).
However, zooming in the filter I see the filter from ublock privacy but ..partially:

Static filter ||googletagservices.com/tag/js/gpt.js$script found in: uBlock filters – Privacy

and not ||googletagservices.com/tag/js/gpt.js$script,redirect=googletagservices.com/gpt.js

@gorhill
Copy link
Member

gorhill commented Nov 21, 2017

By design really: a raw filter with the redirect= option is parsed into a plain block filter, which is what triggers the block (what you see reported with --), and into a redirection directive outside of the static filtering engine, which is what is reported by << (because redirection will also take place if the block is through the dynamic filtering engine).

@gotitbro
Copy link
Author

@mapx- Yes, the filters seem to work. The stock list loads fine after adding them but a lot additional ad requests are created. No better way to resolve this?

@mapx-
Copy link
Contributor

mapx- commented Nov 22, 2017

gotitbro, be my guest searching for other "better way".

Well, you can talk about "better way" only after all the tests (you did no tests), trying redirect filters (still nothing, right ?). And learn - first of all - to say "thanks" to the guys helping you (at least for the time spent to help you).

All this does not exclude someone else could find another (better) way to fix the issue.

@gotitbro
Copy link
Author

@mapx- Sorry, I always make sure to say thanks to anyone helping me on their own accord I don't know why I forgot to do that this time. Thank you for taking your time and helping me I am in no way ungrateful for you helping me out. I appreciate all that you do and again thank you for that.

I was only asking as I did't know any better. Sorry again if that made me come out as disingenuous.

@gotitbro
Copy link
Author

gotitbro commented Dec 21, 2017

@okiehsch Still facing the header issue, unable to use the dropdown menu, search and share buttons #463 (comment) due to these filters in the filter list:

bloomberg.com##.bb-nav-categories:style(z-index: 1000 !important;)
bloomberg.com##.bb-nav-search:style(z-index: 1000 !important;)

Screencapture: https://streamable.com/bdk13

Error URL: https://www.bloomberg.com/news/articles/2017-12-20/bitcoin-tech-stocks-and-xi-top-2017-google-financial-searches

The filters should probably be removed.

@gotitbro
Copy link
Author

@okiehsch @mapx- Can you see if the above issue can be fixed? Thanks.

@uBlockOrigin uBlockOrigin deleted a comment from gotitbro Dec 22, 2017
@gotitbro
Copy link
Author

@mapx- Looks like a comment I made was removed but I can't find out which one. I really try not to make comments that offend or aren't appropriate.

Please do tell me which comment was removed so that I can understand and improve.

@mapx-
Copy link
Contributor

mapx- commented Dec 22, 2017

only noise (from me and you)

see if disabling one of the filters above works for you

add
bloomberg.com#@#.bb-nav-categories:style(z-index: 1000 !important;)

@gotitbro
Copy link
Author

@mapx- Thanks for letting me know.

Yes it works but if one filter is removed the second one is rendered useless. So better remove both the filters.

@mapx-
Copy link
Contributor

mapx- commented Dec 22, 2017

ok, but all other issues are ok now ?

@gotitbro
Copy link
Author

@mapx- No. The filters were added to fix the dropdown menu in selected pages of the Bloomberg website (company info pages) but since they break majority of the dropdown menus on the main Bloomberg website. I think it will be better to remove them.

mapx- added a commit that referenced this issue Dec 22, 2017
@gotitbro
Copy link
Author

@mapx- The stock list issue #463 (comment).

Seems to be fixed on my side by the filters:

bloomberg.com#@#.page-ad
@@||securepubads.g.doubleclick.net/gampad/ads?gdfp_req=1$domain=bloomberg.com
@@||securepubads.g.doubleclick.net/gpt/pubads_impl_$domain=bloomberg.com
@@||googletagservices.com/tag/js/gpt.js$script,domain=bloomberg.com

https://forum.adguard.com/index.php?threads/bloomberg-com-missed-ads-windows.27159/#post-160913

@mapx-
Copy link
Contributor

mapx- commented Dec 22, 2017

  • on the main page https://www.bloomberg.com/ no issue for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants