Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

||adjust.com^ is getting blocked… #9214

Closed
7 tasks done
ThibaultJanBeyer opened this issue May 27, 2021 · 11 comments
Closed
7 tasks done

||adjust.com^ is getting blocked… #9214

ThibaultJanBeyer opened this issue May 27, 2021 · 11 comments
Labels

Comments

@ThibaultJanBeyer
Copy link

ThibaultJanBeyer commented May 27, 2021

Prerequisites

  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin

URL(s) where the issue occurs

Any link with the domain name adjust.
https://www.adjust.com/

You can test is here: https://codepen.io/ThibaultJanBeyer/pen/gOmxZvp

Describe the issue

Well. Adjust is in the blocked list. So even a link to the website like that:

<a href="https://www.adjust.com/">Adjust</a>

Is blocked when the user clicks on it.

I believe that this is faulty. Since adjust is a click tracking tool. We use adjust to wrap our links, something like this https://app.adjust.com/<our-code>?redirect=https://<some-website>. That gives us anonymous metrics on how many times the link was clicked, not even personal info on the user or something.

Seems heavy to me that an adblocker blocks harmless URLs even on a user-initiated action like a click on an A tag.

Screenshot(s)

image (1)

And other times

screenshot_2021-05-27_at_16 43 39

Versions

  • Browser/version: Chrome / 90.0.4430.212 (Official Build) (x86_64)
  • uBlock Origin version: 1.34.0

Settings

  • No changes
@ghost
Copy link

ghost commented May 27, 2021

Are you sure no IP address is sent whatsoever?

@liamengland1
Copy link
Contributor

liamengland1 commented May 27, 2021

Adjust is click tracking and campaign tracking. Why shouldn't it be blocked? The user can bypass the block screen if they want to.

@uBlock-user
Copy link
Contributor

Since adjust is a click tracking tool.

Asked and answered yourself.

@ThibaultJanBeyer
Copy link
Author

ThibaultJanBeyer commented May 27, 2021

Ok well, seems pretty drastic to me to block whole websites. Especially in a tags, src I'd understand but <a>, oof. A simple link to their website adjust.com will get blocked 😅

Anyways thanks for your quick responses and your point that the user can bypass it makes sense, one would hope all users understand what they are doing and where this is coming from if they use your blocker :)

Cheers

@pgl
Copy link
Member

pgl commented May 28, 2021

@ThibaultJanBeyer Two things real quick:

  1. If the service owner supplies a more specific list of subdomains that are dedicated to ads and tracking, then I will replace the entry for the main domain.
  2. I constantly find it weird that people who are interested in tracking services like Adjust, but blocking tracking services, complain that the parent domains are blocked (and don't just add the relevant domain to their allow lists). I mean... I just don't get it.

@ThibaultJanBeyer
Copy link
Author

ThibaultJanBeyer commented May 31, 2021

Hey @pgl,
Yes I don't use uBlock and would not. This was a complaint from a customer. As an engineer, Adjust is super helpful, click tracking but also for deep link handling and redirects depending on OS. I assume that a good uBlock customer experience would be to block adjust but still redirect the user on the <a> tags, but I can see that technically it's not impossible on your end.
Anyways, your call. Was just expressing my thoughts. I understand your arguments, you want to have one of the most restrictive blocker out there, fine. We're looking into writing our own trackers/redirects in the long run.
Thanks for your feedback.

@pgl
Copy link
Member

pgl commented May 31, 2021

@ThibaultJanBeyer OK, so when uBlock blocks the tracking redirect, they are then aware that they're being tracked in this way (which they may not have been before), and they also get a clear option to permanently allow it if they choose. This is one of the primary purposes of uBlock Origin and other blockers.

I do understand that it prevents behaviour that's useful from your perspective, and sorry for the inconvenience, but putting agency back into the hands of users is, I think, important.

@ryanbr
Copy link
Contributor

ryanbr commented Jun 22, 2021

Sorry for being late to this. From https://publicwww.com/websites/%22adjust.com%22/ it's just href links, not a network server item. (example, https://www.lamoda.ru/ , Google play/appstore links)

Blocking ||adjust.com only affects the main www site. The better option is either @pgl to remove adjust or uBO badfilter it. @uBlock-user

uBlock-user added a commit that referenced this issue Jun 23, 2021
@pgl
Copy link
Member

pgl commented Jun 24, 2021

Hey @ryanbr, I consider this a bounce tracker so for now I'll leave it on my list.

If someone supplies a more specific list of subdomains, then I can replace the main entry with those.

@ryanbr
Copy link
Contributor

ryanbr commented Jun 25, 2021

https://app.adjust.com could replace adjust.com if you want to prevent the clickthrough @pgl

@pgl
Copy link
Member

pgl commented Jun 25, 2021

@ryanbr Hmm - there seem to be quite a few other subdomains that are available: https://subdomainfinder.c99.nl/scans/2021-06-25/adjust.com

app-<n>.adjust.com, *.ulink.adjust.com, c., etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants