Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adblock nag on high.fi, download.fi, muropaketti.com #9637

Merged
merged 2 commits into from
Jul 26, 2021

Conversation

peace2000
Copy link
Member

@peace2000 peace2000 commented Jul 26, 2021

URL(s) where the issue occurs

https://high.fi/
https://www.download.fi/
https://muropaketti.com/

Describe the issue

The same as: #9636

Screenshot(s)

The same as: #9636

Versions

Firefox 90.0.2
Ubo 1.37.1b1

Settings

Default

Notes

The same as #9636.

Could there be some kind of universal solution to counter this on all websites? I believe this is even more widely used.

@peace2000 peace2000 changed the title Adblock nag on high.fi and muropaketti.com Adblock nag on high.fi, download.fi, muropaketti.com Jul 26, 2021
@okiehsch okiehsch merged commit 193ae17 into uBlockOrigin:master Jul 26, 2021
@okiehsch
Copy link
Contributor

Sure, you can add
*##+js(nostif, f.parentNode.removeChild(f), 100)
that injects that scriptlet globally, we don't add global injection filters to our lists.
Thanks for the report.

@uBlock-user
Copy link
Contributor

##[class^="div-gpt-ad"] is getting applied even though #@#[class^="div-gpt-ad"] is present, something broke in uBO.

@uBlock-user
Copy link
Contributor

@okiehsch can you reproduce on stable uBO ?

@peace2000
Copy link
Member Author

peace2000 commented Jul 26, 2021

Sure, you can add
*##+js(nostif, f.parentNode.removeChild(f), 100)
that injects that scriptlet globally, we don't add global injection filters to our lists.
Thanks for the report.

Yeah, I can do that but I was thinking everyone else who uses Ubo as well. That nag is caused by blocking fundingchoicesmessages.google.com so I was just wondering if there were a way to fix this universally, without using a global +js filter. Just thinking, I don't know what's possible and what's not. I tried to use resource redirectors but they didn't help...

@uBlock-user
Copy link
Contributor

@peace2000 do you see anti-adblock on stable uBO ?

@okiehsch
Copy link
Contributor

@uBlock-user You are right It's a uBO bug, I can't reproduce with the stable version.

@uBlock-user
Copy link
Contributor

Broken by gorhill/uBlock@c25938f

@uBlock-user
Copy link
Contributor

Should revert both commits.

@okiehsch
Copy link
Contributor

@gorhill

@uBlock-user
Copy link
Contributor

#@#[class^="div-gpt-ad"] gets applied on 1.37.1b0, thats the last working build

@peace2000
Copy link
Member Author

@uBlock-user Well in 1.37 that nag went away. So yeah seems to be a bug then.

@uBlock-user
Copy link
Contributor

@peace2000 happened with #9637 (comment)

@uBlock-user
Copy link
Contributor

Filter count for uBlock badware list also went down from 2059 to 2019 with the latest dev build.

@gorhill
Copy link
Member

gorhill commented Jul 26, 2021

Broken by gorhill/uBlock@c25938f

Sorry, will fix asap

gorhill added a commit to gorhill/uBlock that referenced this pull request Jul 26, 2021
@gorhill
Copy link
Member

gorhill commented Jul 26, 2021

Fixed in 1.37.1b2, and those suffering the regression will have to force an update of filter lists which were updated during 1.37.1b1.

uBlock-user added a commit that referenced this pull request Jul 26, 2021
uBlock-user added a commit that referenced this pull request Jul 26, 2021
@peace2000
Copy link
Member Author

@gorhill Tested, seems to work properly. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants