Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose CNAME-uncloaking as a Privacy option in the Settings pane #1513

Closed
gorhill opened this issue Mar 1, 2021 · 0 comments
Closed

Expose CNAME-uncloaking as a Privacy option in the Settings pane #1513

gorhill opened this issue Mar 1, 2021 · 0 comments
Labels
enhancement New feature or request fixed issue has been addressed

Comments

@gorhill
Copy link
Member

gorhill commented Mar 1, 2021 •
edited
Loading

Now that CNAME-uncloaking has become more common, I think it's time to expose the setting in the user interface and make it easier for users to opt-out if needed, considering that it may causes undue delay in page loading when a proxy is used, as reported in this bugzilla issue: https://bugzilla.mozilla.org/show_bug.cgi?id=1694404.

The setting should be rendered as disabled in browsers not supporting the API for allowing CNAME-uncloaking.
@gorhill gorhill changed the title Expose CNAME-uncloaking as an Privacy option in the Settings pane Expose CNAME-uncloaking as a Privacy option in the Settings pane Mar 1, 2021
@uBlock-user uBlock-user added the enhancement New feature or request label Mar 2, 2021
gorhill added a commit to gorhill/uBlock that referenced this issue Mar 2, 2021
@gorhill
Expose ability to toggle on/off cname-uncloaking to all users
1c3b45f 
Related issue:
- uBlockOrigin/uBlock-issues#1513

Prior to this commit, the ability to enable/disable the
uncloaking of canonical names was only available to advanced
users. This commit make it so that the setting can be
toggled from the _Settings_ pane.

The setting is enabled by default. The documentation should
be clear that the setting should not be disabled unless it
actually solves serious network issues, for example:

https://bugzilla.mozilla.org/show_bug.cgi?id=1694404

Also, as a result, the advanced setting `cnameUncloak` is no
longer available from within the advanced settings editor.
@gwarser gwarser added the fixed issue has been addressed label Mar 2, 2021
gorhill added a commit to gorhill/uBlock that referenced this issue Mar 3, 2021
@gorhill
Fix regression causing exceptions to be thrown
404e625 
Related commit:
- 1c3b45f

Related issue:
- uBlockOrigin/uBlock-issues#1513
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request fixed issue has been addressed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gorhill @gwarser @uBlock-user