-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no-large-media
can cause a large volume of repeated requests for audio file
#3184
Comments
Curious, you are advanced enought to use uBO logger and put |
Seems to be an exaggerated claim. The response headers are downloaded since they are needed for uBO to make a decision, but using Network pane in browser dev tools, I do not see "hundreds of megabytes of data very quickly". After two minutes of broken playback, I see ~800KB. Without the browser tools opened, |
Right, my bad, |
Occurs also on Firefox Mobile 124 and is even worse: drains almost 2x as much as on desktop: 144 Mb/s, this might quickly drain mobile battery and exhaust the limits of payed $ mobile internet packets, and what is even worse, it all happens invisibly in the background for a typical novice user. A good thing in the whole bug scenario is that "block large media elements" is disabled by default and that Firefox user base is much smaller than Chromium, hence majority uf uBO users is not affected. |
I will squeeze in a lightweight fix in the release candidate to address both the case here and the original issue at #1201. The intended behavior is for uBO to not block the media since the media itself is a top level document rather than a secondary resource. There are two code paths to address: First one is that the mime type for the media here is The other issue is probably Firefox-specific, is that when uBO starts to act on the document being loaded, the context is seen as The changes will address those two quirks. |
Related issues: - uBlockOrigin/uBlock-issues#1201 - uBlockOrigin/uBlock-issues#3184 Top-level media resources are not meant to be blocked, see: #2813 (comment)
By the way (just suggestion/info/hint) maybe this could qualify to be fixed too at the same time, I mean it's not perfectly same, but somehow close/similiar: |
Related issues: - uBlockOrigin/uBlock-issues#1201 - uBlockOrigin/uBlock-issues#3184 Top-level media resources are not meant to be blocked, see: #2813 (comment)
I've checked and the bug in the both issues ( Scenario 1 where the bug is fixed: Scenario 2 where the bug still does occur: A seen, the difference which still triggers the bug is the point 2] (in Scenario 2):
|
A better fix would require more changes, I wanted to keep changes to a minimum to avoid delaying release candidate for too long. |
Prerequisites
I tried to reproduce the issue when...
Description
When
no-large-media
is enabled and a large audio file is opened (as the top level document), Firefox makes repeated attempts to stream the audio, downloading hundreds of megabytes of data very quickly.A specific URL where the issue occurs.
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
Steps to Reproduce
Expected behavior
Either the audio file should be blocked in such a way that the browser doesn't attempt to download it again, or alternatively the file should play without interference from uBlock Origin
Actual behavior
The browser makes a large number of requests, downloading hundreds of megabytes in a short time.
Logger output
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
https://static.wikia.nocookie.net/undertale/images/e/ee/MEGALOVANIA_music.ogg/revision/latest?cb=20160401053451
uBO version
1.56.0
Browser name and version
Firefox 124.0
Operating System and version
Manjaro Linux
The text was updated successfully, but these errors were encountered: