::before / ::after no longer hide node as generic filter?

[krystian3w]

Prerequisites

• I verified that this is not a filter issue
  • Filter issues MUST be reported at filter issue tracker
• This is not a support issue or a question
  • Support issues and questions are handled at /r/uBlockOrigin
• I performed a cursory search of the issue tracker to avoid opening a duplicate issue
  • Your issue may already be reported.
• I tried to reproduce the issue when...
  • uBlock Origin is the only extension
  • uBlock Origin with default lists/settings
  • using a new, unmodified browser profile
• I am running the latest version of uBlock Origin
• I checked the documentation to understand that the issue I report is not a normal behavior

Description

##div[class="widget polarisSpid"]::before no longer cut / hide pseudoelements as generic cosmetic filter.

A specific URL where the issue occurs

https://www.folkebladet.no/nyheter/2019/03/15/Kystverket-avsl%C3%A5r-Ytre-%C3%98yfjord-etablering-18661811.ece

https://www.hitra-froya.no/pluss/nyheter/2019/03/15/For-Evaldas-var-nedleggelse-i-nord-starten-p%C3%A5-et-nytt-og-godt-liv-her-i-%C3%B8yregionen-18665600.ece

https://www.rbnett.no/sport/2019/03/14/Etterlyser-bedre-informasjon-fra-klubbene-18660293.ece

https://www.smp.no/nyheter/2019/03/15/Hareid-held-seg-til-%C3%85lesund-18664411.ece

DandelionSprout/adfilt#7 (comment)

Steps to Reproduce

1. paste to my filters panel:

   ##div[class="widget polarisSpid"]::before

   • save changes

2. open demo site

3. blurred on text is still visible:

Expected behavior:

recover works filter as generic

Actual behavior:

filter need TLD or domain name to works

Your environment

• uBlock Origin version: uBO 1.18.6
• Browser Name and version: Firefox 66 RC3
• Operating System and version: Windows 7 Pro x64

---

no affected versions:

uBO <= 1.17.4

[uBlock-user]

@gwarser Did this work before ?

[uBlock-user]

My Filters shows 0 used out of 0​​​​ after adding it, so it's not getting counted it and it's not gonna getting applied either if it's not getting counted as a filter.

[DandelionSprout]

I can confirm first-hand that this has been supported since at least July last year, potentially earlier as well. In fact, DandelionSprout/adfilt#7 was in its modest beginnings about an issue that was resolved by using a :before entry.

[DandelionSprout]

https://github.com/DandelionSprout/adfilt/blob/master/NorwegianList.txt#L967 through L981 contains several examples of this being applied in regular use, and ##.Article-header-body:before was known (or merely believed, depending on some factors) to work as a generic entry at some point in time.

[THEtomaso]

I can confirm first-hand that this has been supported since at least July last year, potentially earlier as well.

March 2017?
gorhill/uBlock@cf123b9#diff-3b15596213ed9ba37fb5b8bb1402a6c2

BTW; ##div[class="widget polarisSpid"]:before works just fine in uBO Legacy.

[gorhill]

The filter requires at least one hostname, it can't be used without a hostname. This has been like this since at least Dec 2017, I didn't check earlier.

Edit: This has been like this since gorhill/uBlock#2448 was fixed, it is not true that this is a new behavior.

[THEtomaso]

This has been like this since gorhill/uBlock#2448 was fixed

If this was the case, then shouldn't uBO Legacy fail to load such generic rules too?

[gorhill]

shouldn't uBO Legacy fail to load such generic rules too?

I would expect so. I will have to investigate further then.

[gorhill]

Ok I was wrong: it seems this is a regression from gorhill/uBlock@261ef8c.

Meanwhile the workaround is to make the filter specific (which is always the preferred approach anyways).

[gwarser]

Cannot test on your example - I don't see it.

Works here:

• disable JS
• add ##.gt3_preloader::after
• load http://jarmarktumski.plock.eu/
• you will see blank page instead of this gif:

---

Make sure "Ignore generic cosmetic filters" is disabled - I had it on right now ;)

[krystian3w]

Try found article from Google, also clear cookies for medonet.

[gorhill]

These are tests for CSS pseudo elements, they succeed: https://gorhill.github.io/uBlock/tests/css-selector-based-cosmetic-filters.html.

[krystian3w]

OK - I suppose similar glitch AS generic:

##.cookie on body/html tag

When for my filter does not work but @gwarser have sometime blank page (breakage).

[gorhill]

medonet.pl##.NTZpopup
medonet.pl##.withNTZpopup::before

Those filters are specific, they are injected unconditionally so they can't suffer from issues affecting generic filters.

[gwarser]

@krystian3w it's about this case where targeted class is added dynamically by script and because of this uBO sometimes does not notice - gorhill/uBlock#1885 ?

[krystian3w]

Yes.

[krystian3w]

About dropped pseudo-class syntax:

#2483 #2442