filter editor search enhancements

[filbo]

Hi,

(mistakenly posted this as uBlockOrigin/uAssets#5241, sorry...)

Within uBO options, when looking at / editing a specific filter list, I was looking for filter lines which would affect github.io. I searched for github and was dismayed to see '1000+' hits in the main 'uBlock filters' list.

Now, there is a trivial workaround for my use case (actually enter github.io); but suppose I were truly looking for an issue with github.com? The 1000+ mentions of https://github.com/uBlockOrigin/uAssets/issues/%d would block me completely.

... which led me to wish for two (and a half) things:

1. search-within-list which is comment-sensitive; that is, ignore lines which are comments
   a. suboption which includes comments which are valid rule syntax, ignoring only human-readable comments; obviously, not the default...

2. search-within-list which is domain-sensitive; that is, find rules which match the given domain or domain-wildcard. This would do wildcard matching in both directions: I enter github.io, it matches rules looking for github.io and github.*; I enter github.*, it matches both of those + github.com. Possibly 'domain' is the wrong concept; searching for *.github.io/*.css ought to be able to match rules with that specificity.

The UI could look something like:

[filbo]

Or possibly like this (except probably a pulldown menu rather than radio buttons):

[uBlock-user]

You mean to suggest "Don't count results from commented lines" right ?

[gwarser]

This field supports regex (/.../), assertions should work, but they don't :(

[e: Meh, lookbehind assertions still not implemented]

Maybe because multiline is enabled by default?

/^[^!\n][^\n]+github/ ???

[filbo]

I mean to suggest multiple things.

Sometimes a comment is exactly what I'm looking for. Other times it's something about a rule. Therefore, it would be helpful to have a control in the widget, telling it whether or not to consider comments.

Then I additionally thought of a sub-control which would have it search rules + commented-out rules, but not 'real' comments. This would search all rule lines, plus all commented-out lines which parse successfully as rules. I particularly imagine using this when I had commented out some rule, thinking it was no longer needed, then realized it was still needed. The likely search string I remember for that rule is something that would hit in a lot of 'real' comments, so omitting those would help.

...

and, domain match would help quickly ask a particular list: which of these rules apply to this site I am scrutinizing right now?

[gorhill]

So far, what I am reading is a request to add a lot of effort, code, development time and future maintenance for "what if I want to search for github.com". @gwarser provided a solution for this one case.

[gorhill]

Maybe because multiline is enabled by default?

/^[^!\n][^\n]+github/ ???

Yes, I switched multiline to false here, and that fixes the search. However, there seem to be a CodeMirror bug, because after this, the search itself works as expected, but the scrollbar annotations are still reporting 1000+ hits. I created a fix locally, I will have to create a pull request to CodeMirror.

[gwarser]

@gorhill, if you are looking at CodeMirror regex, maybe you will also take a look at this codemirror/codemirror5#5428

[gorhill]

I consider the issue addressed here with commit gorhill/uBlock@72bbcdd. That commit prevent multiline matches when using a regular expression. Using a regular expression is the way to address fancy search behavior -- I decline to work on modifying the current UI as suggested.

Before the fix: /^[^!\n][^\n]+github/
After the fix: /^[^!].+github/