-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filter editor search enhancements #493
Comments
You mean to suggest "Don't count results from commented lines" right ? |
This field supports regex ( [e: Meh, lookbehind assertions still not implemented] Maybe because multiline is enabled by default?
|
I mean to suggest multiple things. Sometimes a comment is exactly what I'm looking for. Other times it's something about a rule. Therefore, it would be helpful to have a control in the widget, telling it whether or not to consider comments. Then I additionally thought of a sub-control which would have it search rules + commented-out rules, but not 'real' comments. This would search all rule lines, plus all commented-out lines which parse successfully as rules. I particularly imagine using this when I had commented out some rule, thinking it was no longer needed, then realized it was still needed. The likely search string I remember for that rule is something that would hit in a lot of 'real' comments, so omitting those would help. ... and, domain match would help quickly ask a particular list: which of these rules apply to this site I am scrutinizing right now? |
So far, what I am reading is a request to add a lot of effort, code, development time and future maintenance for "what if I want to search for |
Yes, I switched |
@gorhill, if you are looking at CodeMirror regex, maybe you will also take a look at this codemirror/codemirror5#5428 |
…ndaries Related issue: - uBlockOrigin/uBlock-issues#493
I consider the issue addressed here with commit gorhill/uBlock@72bbcdd. That commit prevent multiline matches when using a regular expression. Using a regular expression is the way to address fancy search behavior -- I decline to work on modifying the current UI as suggested. Before the fix: |
…ndaries Related issue: - uBlockOrigin/uBlock-issues#493
Hi,
(mistakenly posted this as uBlockOrigin/uAssets#5241, sorry...)
Within uBO options, when looking at / editing a specific filter list, I was looking for filter lines which would affect github.io. I searched for
github
and was dismayed to see '1000+' hits in the main 'uBlock filters' list.Now, there is a trivial workaround for my use case (actually enter
github.io
); but suppose I were truly looking for an issue with github.com? The 1000+ mentions ofhttps://github.com/uBlockOrigin/uAssets/issues/%d
would block me completely.... which led me to wish for two (and a half) things:
search-within-list which is comment-sensitive; that is, ignore lines which are comments
a. suboption which includes comments which are valid rule syntax, ignoring only human-readable comments; obviously, not the default...
search-within-list which is domain-sensitive; that is, find rules which match the given domain or domain-wildcard. This would do wildcard matching in both directions: I enter
github.io
, it matches rules looking forgithub.io
andgithub.*
; I entergithub.*
, it matches both of those +github.com
. Possibly 'domain' is the wrong concept; searching for*.github.io/*.css
ought to be able to match rules with that specificity.The UI could look something like:
![uBO-filter-search](https://user-images.githubusercontent.com/3022180/55194168-1c9bd700-5166-11e9-8c09-f5c32fd34ecc.png)
The text was updated successfully, but these errors were encountered: