Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"My filters" are ignored when there is a 3rd party "Filter lists" exception rule #526

Closed
360up opened this issue Apr 16, 2019 · 9 comments
Closed
Labels
duplicate This issue or pull request already exists

Comments

@360up
Copy link

360up commented Apr 16, 2019

If you e.g. have a filter ||example.org/$script in My filters and there is an exception filter in any of the active filter lists e.g. @@||example.org/example.js$script this exception takes precedence over your own filter.
Yes you could add the $important flag to your filter, but then you are not able to write own exceptions for that filter anymore.

Regardless, exception rules in 3rd party filter lists should be limited to their very own list only and not take precedence over any filter specified outside that list.

Alternatively add a filter lists setting: "Ignore 3rd party Exception Filters"

@okiehsch
Copy link

Regardless, exception rules in 3rd party filter lists should be limited to their very own list only and not take precedence over any filter specified outside that list.

How would you then deal with site breakage caused by a 3rd party filter or with bait requests that if you don't allow them will result in the site beeing blocked if one uses an adblocker.

@uBlock-user
Copy link
Contributor

uBlock-user commented Apr 16, 2019

If you e.g. have a filter ||example.org/$script in My filters and there is an exception filter in any of the active filter lists e.g. @@||example.org/example.js$script this exception takes precedence over your own filter.

Use @@||example.org/example.js$script,badfilter to disable that exception filter or start using Dynamic Filtering.

@uBlock-user uBlock-user added invalid not a uBlock issue duplicate This issue or pull request already exists and removed invalid not a uBlock issue labels Apr 16, 2019
@uBlock-user
Copy link
Contributor

Duplicate of gorhill/uBlock#3353

@uBlock-user uBlock-user marked this as a duplicate of gorhill/uBlock#3353 Apr 16, 2019
@gorhill
Copy link
Member

gorhill commented Apr 19, 2019

@uBlock-user
Copy link
Contributor

@gorhill would you be implementing that priority feature in uBO ?

@gorhill
Copy link
Member

gorhill commented Apr 19, 2019

As pointed out in the ABP issue, it is something I would consider for the sake of filter list maintainers. I could possibly provide an incomplete version (network filters only at first) of this behind a hidden settings, I need to think more about this -- and of course filter list maintainers feedback would help to assess how useful this could be.

@gwarser gwarser marked this as not a duplicate of gorhill/uBlock#3353 Oct 6, 2019
@gwarser
Copy link

gwarser commented Oct 6, 2019

Duplicate of gorhill/uBlock#1520

@gwarser gwarser marked this as a duplicate of gorhill/uBlock#1520 Oct 6, 2019
@gorhill
Copy link
Member

gorhill commented Oct 6, 2019

I could possibly provide an incomplete version

Since this was brought up, I will say I had a change of mind.

User filters should never behave differently than if they were 3rd-party filters, otherwise this will make the work of filter list maintainers more difficult since the filters they craft locally may end up behaving differently once moved to a filter lists. This also applies for users who decide to move their custom filters into a custom list.

So in the end, it's not a good idea to have user filters behave differently than 3rd-party filters.

@uBlock-user
Copy link
Contributor

Besides, users already have options such as $important/$badfilter to deal with rogue filters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

5 participants