Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3rd-party filter rules should not override personal blocker rules #1520

Closed
tobbi opened this issue Apr 1, 2016 · 3 comments
Closed

3rd-party filter rules should not override personal blocker rules #1520

tobbi opened this issue Apr 1, 2016 · 3 comments
Labels

Comments

@tobbi
Copy link

tobbi commented Apr 1, 2016

Read first: https://github.com/gorhill/uBlock/blob/master/CONTRIBUTING.md

Describe the issue

I found that an EasyList classification of an image overrides a personal blocking rule for an image which I created using element picker.

One or more specific URLs where the issue occurs

https://en.wikipedia.org/wiki/Murder_of_Du%27a_Khalil_Aswad

Steps for anyone to reproduce the issue

  1. Open the page above, open element picker.
  2. Create a filter for one of the image elements on that page, mine is the following:
    ! 1.4.2016, 02:44:46 https://en.wikipedia.org/wiki/Murder_of_Du%27a_Khalil_Aswad
    ||upload.wikimedia.org/wikipedia/en/thumb/2/25/AswadStoning.jpg/220px-AswadStoning.jpg
  3. Reload the page.

Result:
Image element is not blocked anymore due to easylist overriding the images on upload.wikimedia.org as whitelisted. However, I think that specific user-rules should override even easylist.

Your settings

  • Browser/version: Firefox Nightly 48.0a1
  • uBlock Origin version: 1.6.6
Your filter lists

Default filter lists

Your custom filters (if any)

(see above).

@tobbi tobbi changed the title EasyList subscriptions override personal blocker rules? EasyList rules override personal blocker rules? Apr 1, 2016
@tobbi tobbi changed the title EasyList rules override personal blocker rules? 3rd-party filter rules should not override personal blocker rules Apr 1, 2016
@tobbi
Copy link
Author

tobbi commented Apr 1, 2016

I just read https://github.com/gorhill/uBlock/wiki/Element-picker#the-removed-element-reappears-when-you-reload-the-page and I it is my opinion that personal filter rules should have precedence over 3rd party rules.

@gorhill
Copy link
Owner

gorhill commented Apr 1, 2016

Use the important filter option -- that's its purpose.

@tobbi
Copy link
Author

tobbi commented Apr 1, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants