This repository has been archived by the owner on May 4, 2022. It is now read-only.
Simplify build #335
Merged
Simplify build #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These targets are for building, watching, and serving the docs and static sub-projects. The Gruntfile.js should be obsolete with this change.
|
I like it. Does anything change in our documentation here: https://github.com/UW-Madison-DoIT/uw-frame/blob/master/README.md or https://github.com/UW-Madison-DoIT/uw-frame/blob/master/docs/markdown/quickstart.md which results in the io page here being updated: http://uw-madison-doit.github.io/uw-frame/latest/#/md/quickstart |
timlevett
approved these changes
Oct 12, 2016
timlevett
suggested changes
Oct 12, 2016
|
|
|
||
| RUN apt-get update && apt-get install -y bzip2 && apt-get install -y git | ||
|
|
||
| # Add frame | ||
| COPY tools /build/tools | ||
| copy docs /build/docs |
There was a problem hiding this comment.
uppercase COPY is more conventional
|
👍 less is more! |
timlevett
approved these changes
Oct 13, 2016
vertein
pushed a commit
to vertein/uportal-app-framework
that referenced
this pull request
Jun 3, 2017
MUMUP-2149 : rename sample staticFeeds
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was to move functionality found in build.sh files and Grunt configuration into the npm build with the goal of simplifying the build process by reducing the number of tools required.