[WIP] Java 10 Support #1007

ChristianMurphy · 2017-09-17T19:09:34Z

🏗️ Work in Progress

Checklist

the individual contributor license agreement is signed
commit message follows commit guidelines

Description of change

Proof of concept investigating what changes will be needed to support Java 9.

🔲 TODO

Upgrade resource server to work with Java 9 and 10
Upgrade embedded CAS to a version that supports Java 9 and 10

☑️ Done

Restore Error Prone (with version that supports Java 9)
Set source compatibility version in Gradle
Setup Continuous Integration with Java 9

Resolve

Execution failed for task ':uPortal-utils:uPortal-utils-core:compileJava'.
> java.lang.NoClassDefFoundError: javax/annotation/Generated

asgrant · 2017-09-26T15:17:13Z

@ChristianMurphy thanks for taking a look at this. We are testing at OU with OpenJDK 9.

ChristianMurphy · 2017-09-26T19:56:52Z

No problem, 😄
I have limited bandwidth at the moment so I may not be able to get back to this for a while. 🕐
If Oakland has any available bandwidth, assistance would be much appreciated. 🙇

asgrant · 2017-09-29T20:12:10Z

@ChristianMurphy @Josh31415 is looking at this issue. Looks like we have a few JAXB issues. Josh will fill in the details as he moves along.

ChristianMurphy · 2017-10-10T16:50:08Z

Rebased changes off of latest master, Gradle 4.2.1 resolved some conflicts between Gradle and openJDK 9.

JoshBrudnak · 2017-10-11T14:45:41Z

@ChristianMurphy I am working on the javax.annotation.Generated class not found error. The problem seems to be that the javax.annotation package was moved to the java.xml.ws.annotation module.

ChristianMurphy · 2017-10-11T14:50:52Z

Thanks @JoshBrudnak! 🙇

ChristianMurphy · 2017-10-18T17:59:05Z

rebased on current master

ChristianMurphy · 2017-11-06T16:26:02Z

Rebased on master, re-adds error prone, which now supports Java 9.

ChristianMurphy · 2017-11-06T16:28:44Z

@JoshBrudnak any luck looking into the generated class not found error?

JoshBrudnak · 2017-11-06T16:46:30Z

@ChristianMurphy Yes I was able to fix the generated class error by adding its new path to the dependencies list. There is also an problem with the jaxb dependencies in uPortal-api/uPortal-api-search that I am currently working on.

ChristianMurphy · 2017-11-07T15:35:45Z

Awesome, thanks @JoshBrudnak!
Any chance that the current changes could be committed and a PR opened targeting Jasig:master or ChristianMurphy:feature/support-java-9?

JoshBrudnak · 2017-11-07T15:43:57Z

@ChristianMurphy Yes, will do 👍. I was also able to get the jaxb dependencies problem resolved.

fix java 9 issues

ChristianMurphy

Thanks @JoshBrudnak!

ChristianMurphy · 2017-11-13T19:23:28Z

gradle.properties

@@ -38,6 +38,7 @@ servletApiDependency=javax.servlet:javax.servlet-api:3.0.1
 portletApiDependency=org.apache.portals:portlet-api_2.1.0_spec:1.0

 # Dependency Versions
+activationVersion:1.0.2


❓ is activationVersion:1.0.2 intended here or should this be activationVersion=1.0.2?

No, that was a mistake sorry.

ChristianMurphy · 2017-11-13T19:24:46Z

uPortal-utils/uPortal-utils-core/build.gradle

@@ -78,6 +80,9 @@ dependencies {
    compileOnly "${servletApiDependency}"
 }

+sourceCompatibility = '9'


🤔 its interesting that this needed to be set here.
I thought allprojects would have covered this 🤷‍♂️

ChristianMurphy · 2017-11-13T19:34:30Z

build.gradle

@@ -75,7 +75,7 @@ allprojects {
    }

    // Version has to be set directly here, using a variable does not set Java compatability version
-    sourceCompatibility = 1.8
+    sourceCompatibility = 1.9


❓ Open Question ❓
How do we want to handle Java versions with Semantic Versioning?
Upgrading from Java 8 to Java 9 could be considered breaking change (major), however Java 9 is something that would be valuable to get into the 5.x release line.

My thought is would be to set a lower target compatibility allowing this to be added in a feature (minor) release.

sourceCompatibility = 1.9 targetCompatibility = 1.8

Then removing the backwards target in uPortal 6.

ChristianMurphy · 2017-11-13T19:38:15Z

🚧 👷‍♂️ 🐧 ⛔ CI is running into issues with JpaClusterLockDao

/home/travis/build/Jasig/uPortal/uPortal-utils/uPortal-utils-core/src/main/java/org/apereo/portal/concurrency/locking/JpaClusterLockDao.java:232: error: cannot find symbol
                        query.using(ClusterMutex_.name, mutexName);
                                    ^
  symbol: variable ClusterMutex_

https://travis-ci.org/Jasig/uPortal/jobs/301570883#L1008-L1009

drop Java 8 from test matrix

tbroyer · 2018-06-10T17:35:23Z

Fwiw, if you want Java 10 support for Error Prone, you need to use net.ltgt.errorprone-javacplugin; it requires Java 9+ and Gradle 4.6+. If you need to keep Java 8 support, then you'd have to conditionally apply (and configure!) either net.ltgt.errorprone (supports Java 8 and 9) or net.ltgt.errorprone-javacplugin (requires Java 9+)

I'm working on bringing the configuration of net.ltgt.errorprone-javacplugin to net.ltgt.errorprone so it'll be easier to conditionally apply the plugins (and use the same task configuration whichever the plugin); and will eventually deprecate, and then replace net.ltgt.errorprone next year when Java 8 is EOL.

ChristianMurphy · 2018-06-10T18:19:58Z

Fwiw, if you want Java 10 support for Error Prone, you need to use net.ltgt.errorprone-javacplugin; it requires Java 9+ and Gradle 4.6+.

Thanks @tbroyer! 🙇

If you need to keep Java 8 support

We are moving toward using Java 10+ and dropping Java <= 9 support.

ChristianMurphy · 2019-05-20T17:49:56Z

The merge conflicts are becoming untenable, closing this.
Continuing language upgrade at #1706.

ChristianMurphy added this to the 5.0.0 milestone Sep 18, 2017

ChristianMurphy force-pushed the feature/support-java-9 branch from d5f7113 to d1ccca8 Compare October 10, 2017 16:43

ChristianMurphy changed the title ~~[POC] [WIP] Java 9 Support~~ [WIP] Java 9 Support Oct 18, 2017

This was referenced Oct 18, 2017

[WIP] Java 9 Support uPortal-Project/AnnouncementsPortlet#56

Closed

Support Java 9 uPortal-Project/FeedbackPortlet#18

Closed

ChristianMurphy force-pushed the feature/support-java-9 branch from d1ccca8 to 7a124e5 Compare October 18, 2017 17:58

ChristianMurphy modified the milestones: 5.0.0, 5.1.0 Oct 24, 2017

ChristianMurphy force-pushed the feature/support-java-9 branch from 7a124e5 to 19d5b40 Compare November 6, 2017 16:24

ChristianMurphy added 2 commits November 6, 2017 09:31

build(gradle): set source compatibility to Java 9

2b7c956

ci(travis): add Oracle Java 9 to Linux build matrix

3692260

ChristianMurphy force-pushed the feature/support-java-9 branch from 19d5b40 to 3692260 Compare November 6, 2017 16:31

JoshBrudnak and others added 2 commits November 13, 2017 13:23

fixed some java 9 issues with dependencies

373e673

Merge pull request #4 from JoshBrudnak/feature/support-java-9

7b8604e

fix java 9 issues

ChristianMurphy commented Nov 13, 2017

View reviewed changes

ci: update AppVeyor to test with Java 9

2590ba1

drop Java 8 from test matrix

Merge branch 'master' of into feature/support-java-9

4868f54

ChristianMurphy force-pushed the feature/support-java-9 branch from fa9a153 to 4868f54 Compare April 24, 2018 01:02

ChristianMurphy modified the milestones: 5.1.0, 5.2.0 May 5, 2018

Merge branch 'master' into feature/support-java-9

29d56c5

ChristianMurphy added 4 commits June 22, 2018 08:14

Merge branch 'master' into feature/support-java-9

cbac644

Merge branch 'master' into feature/support-java-9

4dc2635

build: use error prone javac plugin

f7ce203

Merge branch 'master' into feature/support-java-9

588d571

ChristianMurphy modified the milestones: 5.2.0, 5.3.0 Aug 3, 2018

ChristianMurphy modified the milestones: 5.3.0, 5.4.0 Oct 10, 2018

ChristianMurphy mentioned this pull request Dec 18, 2018

Support Gradle 5+ #1472

Closed

ChristianMurphy modified the milestones: 5.4.0, 5.4.1, 5.5.0 Dec 21, 2018

ChristianMurphy modified the milestones: 5.5.0, 5.6.0 Apr 10, 2019

ChristianMurphy mentioned this pull request May 20, 2019

Java 11 Support #1705

Closed

4 tasks

ChristianMurphy closed this May 20, 2019

ChristianMurphy deleted the feature/support-java-9 branch May 20, 2019 17:50

ChristianMurphy mentioned this pull request May 20, 2019

Java 11 Support #1706

Closed

4 tasks

ChristianMurphy added stale and removed help wanted work in progress labels May 20, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Java 10 Support #1007

[WIP] Java 10 Support #1007

ChristianMurphy commented Sep 17, 2017 •

edited

Loading

asgrant commented Sep 26, 2017

ChristianMurphy commented Sep 26, 2017

asgrant commented Sep 29, 2017

ChristianMurphy commented Oct 10, 2017

JoshBrudnak commented Oct 11, 2017

ChristianMurphy commented Oct 11, 2017

ChristianMurphy commented Oct 18, 2017

ChristianMurphy commented Nov 6, 2017

ChristianMurphy commented Nov 6, 2017

JoshBrudnak commented Nov 6, 2017

ChristianMurphy commented Nov 7, 2017

JoshBrudnak commented Nov 7, 2017

ChristianMurphy left a comment

ChristianMurphy Nov 13, 2017

JoshBrudnak Nov 14, 2017

ChristianMurphy Nov 13, 2017

ChristianMurphy Nov 13, 2017

ChristianMurphy Nov 13, 2017

ChristianMurphy commented Nov 13, 2017

tbroyer commented Jun 10, 2018

ChristianMurphy commented Jun 10, 2018

ChristianMurphy commented May 20, 2019 •

edited

Loading

[WIP] Java 10 Support #1007

[WIP] Java 10 Support #1007

Conversation

ChristianMurphy commented Sep 17, 2017 • edited Loading

Checklist

Description of change

🔲 TODO

☑️ Done

asgrant commented Sep 26, 2017

ChristianMurphy commented Sep 26, 2017

asgrant commented Sep 29, 2017

ChristianMurphy commented Oct 10, 2017

JoshBrudnak commented Oct 11, 2017

ChristianMurphy commented Oct 11, 2017

ChristianMurphy commented Oct 18, 2017

ChristianMurphy commented Nov 6, 2017

ChristianMurphy commented Nov 6, 2017

JoshBrudnak commented Nov 6, 2017

ChristianMurphy commented Nov 7, 2017

JoshBrudnak commented Nov 7, 2017

ChristianMurphy left a comment

Choose a reason for hiding this comment

ChristianMurphy Nov 13, 2017

Choose a reason for hiding this comment

JoshBrudnak Nov 14, 2017

Choose a reason for hiding this comment

ChristianMurphy Nov 13, 2017

Choose a reason for hiding this comment

ChristianMurphy Nov 13, 2017

Choose a reason for hiding this comment

ChristianMurphy Nov 13, 2017

Choose a reason for hiding this comment

ChristianMurphy commented Nov 13, 2017

tbroyer commented Jun 10, 2018

ChristianMurphy commented Jun 10, 2018

ChristianMurphy commented May 20, 2019 • edited Loading

ChristianMurphy commented Sep 17, 2017 •

edited

Loading

ChristianMurphy commented May 20, 2019 •

edited

Loading