Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/favorites api #2533

Merged
merged 10 commits into from
Dec 16, 2022
Merged

Feat/favorites api #2533

merged 10 commits into from
Dec 16, 2022

Conversation

cbeach47
Copy link
Contributor

@cbeach47 cbeach47 commented Aug 17, 2022

Checklist
Description of change

Build out of the portlet-list API endpoint feature.

Tests to support this feature is in uPortal-Project/uPortal-start#575

Future efforts:

  • Setup the portlet-list portlet entries to be a foreign key constraint on portlet definition fnames.
  • Include 'details' parameter in portlet-list retrieval to inflate portlets (removes the need for a second API call)
  • Paginate retrieval of all portlet-lists
  • Gradle task to migrate old favorites to portlet list favorites

@cbeach47
Copy link
Contributor Author

I don't expect the overall structure to change - possibly tweaks as I finish out the integration tests.

@cbeach47 cbeach47 marked this pull request as ready for review August 23, 2022 16:25
@cbeach47
Copy link
Contributor Author

hardened the logging messages as per Sonatype. I think the rest are OK to ignore for now, basic logging of exceptions / stack traces, or existing issues.

@bjagg
Copy link
Member

bjagg commented Dec 16, 2022

For expediency, I am going to merge and then remove the duplicate class in a new PR.

@bjagg bjagg merged commit 1fe55e3 into uPortal-Project:master Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants