Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tab name and portlet info to analytics events #2694

Merged

Conversation

bjagg
Copy link
Member

@bjagg bjagg commented Aug 23, 2023

Checklist
  • the individual contributor license agreement is signed
  • commit message follows commit guidelines
  • tests are included
  • documentation is changed or added
  • new security keys and comments added to security.properties
  • new general keys and comments added to portal.properties
  • any changes that impact configuration or the database DDL added to CHANGES.md
  • message properties have been updated with new phrases
  • view conforms with WCAG 2.0 AA
Description of change

Add tab (name) and portlet info (ID and title) to analytics events.

@bjagg bjagg self-assigned this Aug 23, 2023
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bjagg! looks good

Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like ESLint may need a configuration update

Copy link
Contributor

@cbeach47 cbeach47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bjagg - Fixed the package lock conflict and confirmed the new details are being sent in the request locally.

Seems a bit odd that the tab_name is scraping the text content. It's ending up with values such as tab_name: "TestingEdit text Testing". If this is as-intended, then 👍

Confirmed that layering the commits from #2695 onto this code persists the new fields.

@bjagg bjagg merged commit b29c1ca into uPortal-Project:master Nov 4, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants