Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/AnalyticsEventUpdate add new features to AnalyticsPortalEvent an… #2695

Merged
merged 2 commits into from Nov 4, 2023

Conversation

mgillian
Copy link
Contributor

…d factory

Checklist
Description of change

Additional data is captured as part of an AnalyticsPortalEvent being generated by the UI call to the AnalyticsPortalEventControlller REST endpoint

Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mgillian!
When you get a chance, please run ./gradlew goJF to format the code so CI passes, thanks!

@ChristianMurphy ChristianMurphy requested review from ChristianMurphy and cbeach47 and removed request for ChristianMurphy November 2, 2023 21:00
ChristianMurphy

This comment was marked as duplicate.

Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting looks good, I have not tested otherwised

Copy link
Contributor

@cbeach47 cbeach47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed locally on Java 11. LGTM 👍

@bjagg bjagg merged commit 442d1c5 into uPortal-Project:master Nov 4, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants