Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MIT license #266

Merged
merged 1 commit into from Nov 16, 2017
Merged

Add MIT license #266

merged 1 commit into from Nov 16, 2017

Conversation

pbinkley
Copy link
Member

MIT license is approved for DI work on Jupiter.

MIT license is approved for DI work on Jupiter.
@cwant
Copy link
Contributor

cwant commented Nov 16, 2017

I would remove the "MIT License" line from the top of the file, as I think it affects how Github parses the file. Compare for example the view of your license file, and an MIT Licence from another project:

https://github.com/ualbertalib/jupiter/blob/eafc5b839f3fb447ac3f89fd21fb2b21e4c7f5ff/LICENSE

https://github.com/mitmproxy/mitmproxy/blob/master/LICENSE

Github has added a summary of rights permissions/restrictions for the other file that isn't present in your file (and the only difference I can see is that first "MIT License" line).

@cwant
Copy link
Contributor

cwant commented Nov 16, 2017

Actually, it's quite possible the following is needed to add a license after the fact:

https://help.github.com/articles/adding-a-license-to-a-repository/

@pbinkley
Copy link
Member Author

I used the method Chris linked to, so that first line is part of the template Github provides. Maybe that summary only gets displayed when the license is in master? Github wants to display "how repositories on GitHub are licensed", so a license file in a non-master branch might not trigger their display. https://github.com/blog/2252-license-now-displayed-on-repository-overview . Why don't we merge and see how it looks, and fix it if it still doesn't show.

@cwant cwant merged commit ad8aab3 into master Nov 16, 2017
@cwant
Copy link
Contributor

cwant commented Nov 16, 2017

Yeah, merging into master did the trick.

@murny murny deleted the add-license-1 branch January 4, 2018 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants