Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up precondition data and check file content #12

Merged
merged 17 commits into from
Oct 10, 2023
Merged

Set up precondition data and check file content #12

merged 17 commits into from
Oct 10, 2023

Conversation

GoZaddy
Copy link

@GoZaddy GoZaddy commented Sep 19, 2023

No description provided.

@GoZaddy GoZaddy self-assigned this Sep 19, 2023
@@ -293,13 +312,13 @@ export default {
// cy.do(Select({ name: 'header[2].timezone' }).choose('America/New_York'));

cy.do(Select({ name: 'header[3].type' }).choose('Whitespace'));
cy.do(TextField({ name: 'header[3].repeat' }).fillIn('1'));
cy.do(TextField({ name: 'header[1].repeat' }).fillIn('1'));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it header[1] instead of header[3] here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nhanaa Must be an error from when I was resolving the merge conflict. Will fix ASAP!


cy.do(Select({ name: 'header[4].type' }).choose('Text'));
cy.do(TextField({ name: 'header[4].text' }).fillIn('DU LIBRARY'));

cy.do(Select({ name: 'header[5].type' }).choose('Whitespace'));
cy.do(TextField({ name: 'header[5].repeat' }).fillIn('1'));
cy.do(TextField({ name: 'header[1].repeat' }).fillIn('1'));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

'Test Service Point',
'40000000-0000-1000-8000-000000000000'
),
feeFineOwnerOne: {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the criteria, doesn't the fee/fine owner have to be a valid owner and not random postfix? Possibly different for mocking the data, however, currently cornell test is failing on cypress because the fee/fine owner its trying to select. doesn't exists.

Screenshot 2023-09-21 at 12 25 32 PM

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we create a test fee/fine owner before running the tests and destroy it after the tests.

I had the same problem when i started adding the preconditions. Can you confirm that your OKAPI_HOST env variable in cypress.config.js has the same prefix as your baseUrl in the same file? If your baseUrl is https://folio-dev-bama-diku.ci.folio.org/, your OKAPI_HOST should be https://folio-dev-bama-okapi.ci.folio.org.

The folio-testing site also has an accompanying okapi host: https://folio-testing-cypress-okapi.ci.folio.org

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, sorry about that! My OKAPI_HOST url was incorrect, but it is working now. Looks good.

@danetsao danetsao self-requested a review September 25, 2023 19:31
@GoZaddy GoZaddy requested a review from nhanaa October 9, 2023 16:24
@GoZaddy GoZaddy merged commit f1ed3a4 into master Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants