Skip to content

Commit

Permalink
Never treat Proguard warnings as errors
Browse files Browse the repository at this point in the history
  • Loading branch information
uazo committed Apr 18, 2024
1 parent 8ea3639 commit 7ed682e
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 0 deletions.
1 change: 1 addition & 0 deletions build/cromite_patches_list.txt
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,7 @@ Temp-PerformanceNavigationTiming-privacy-fix.patch
Temp-disable-predictive-back-gesture.patch
TEMP-Add-a-log-to-track-strange-behavior.patch
Temp-guard-FileSystemAccessPersistentPermissions.patch
Never-treat-Proguard-warnings-as-errors.patch
Fix-chromium-build-bugs.patch

eyeo-beta-118.0.5993.48-base.patch
Expand Down
25 changes: 25 additions & 0 deletions build/patches/Never-treat-Proguard-warnings-as-errors.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
From: uazo <uazo@users.noreply.github.com>
Date: Thu, 18 Apr 2024 07:01:52 +0000
Subject: Never treat Proguard warnings as errors

---
build/config/android/internal_rules.gni | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/build/config/android/internal_rules.gni b/build/config/android/internal_rules.gni
--- a/build/config/android/internal_rules.gni
+++ b/build/config/android/internal_rules.gni
@@ -1262,9 +1262,9 @@ if (enable_java_templates) {
"--source-file",
_source_file_template,
]
- if (treat_warnings_as_errors) {
- _args += [ "--warnings-as-errors" ]
- }
+ # if (treat_warnings_as_errors) {
+ # _args += [ "--warnings-as-errors" ]
+ # }

if ((!defined(invoker.proguard_enable_obfuscation) ||
invoker.proguard_enable_obfuscation) && enable_proguard_obfuscation) {
--

0 comments on commit 7ed682e

Please sign in to comment.