Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repost issue "Disable Blink "Energy Saver"" because github bug censored or deleted the issue #728

Closed
5 tasks done
trimakuss opened this issue Jan 18, 2024 · 5 comments
Closed
5 tasks done
Labels
working on it working on it

Comments

@trimakuss
Copy link

Preliminary checklist

  • I have read the README
  • I have read the FAQs.
  • I have searched existing issues for my feature request. This is a new issue (NOT a duplicate) and is not related to another issue.
  • I have searched wont fix issues and this request is not among them
  • This is a feature request for the Cromite browser; not the website nor F-Droid nor anything else.

Is your feature request related to privacy?

Is there a patch available for this feature somewhere?

Yesn Chromiuim browser 122

https://chromium-review.googlesource.com/c/chromium/src/+/5046375

Describe the solution you would like

Enable saver energy feature even wihout battery ou plugged in in desktop laptops :

I copy paste my thread censored or deleted by github in a mysterious way (probably because I'm a recent account) so that Mr @uazo remembers this suggestion and for documentation and archiving reasons :) :

" It's not clear what the energy saver option exactly does, but since popular web browsers disable this option when plugged in, perhaps energy saver helps limit user data collection and limits background processes. and unnecessary services and automatically minimize the impact of trackers and cookies which allows less data to be collected and recorded and minimize the size of the session storage on the hard drive or deactivate cache and ads which can improve privacy

Describe alternatives you have considered
When unplugged, user can enable "Energy Saver" option but when plugged , the energy saver is automatically disabled even when the user wants to enable this option when plugged in, so the solution is perhaps to make the browser believe that we are using the battery even if we are using a desktop computer without a battery or a laptop which does not have a battery or laptop with the battery is disabled !

@ [PF4Public]

One would need a better confirmation for this claim in order to permanently enable this feature, not just a guess.

@ drimisssss

Why popular browsers except edge browser and even in microsoft edge browser, this feature is not enabled by default, why many browsers don't like users to enable this feature when plugged in? logically we can think that unnecessary services which can track user activity will be deactivated, it is a question of logical deduction

@ [PF4Public]
That's still a guess.

@ drimisssss

the guess is that you guess that this feature doesn't improve privacy,

I read there are a lot of undocumented command line flags....
List of Chromium Command Line Switches
https://peter.sh/experiments/chromium-command-line-switches/

so neither me nor you nor even developers , we don't really know what exactly this option does because in essence it is scalable and new web technologies evolve, when the battery is about to die, logically the browser will shut down unnecessary processes and more there is deactivated processes, the more confidentiality improves, it's automatic and statistical

@ [Fermi69]
"neither me nor you nor even developers , we don't really know what exactly this option does"

That is exactly why implementing this is a terrible idea. It would be haphazard to move forward with this proposed change until there is better confirmation that Energy Saver improves privacy.

If you would like to add substance to your claim, perhaps looking into Chromium code would be good start

https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/performance_manager/user_tuning/battery_saver_mode_manager.cc

So far I'm not seeing anything which affects telemetry. In fact, I'm inclined to believe that all energy saver does is render content at 30 fps (ref).

@ uazo
Owner
uazo commented last week

"Well, you have already said it all. :)

But I would just add one point: it is with these insights that I have developed some of my patches.
so before saying absolutely not, I would say that a code check should be done.

@ drimisssss you should look for documentation that supports your thesis, if you are unable to read the chromium code.

@ uazo uazo changed the title Enable "Energy Saver" feature which automatically improves privacy even when plugged in to make the "energy saver" option permanently available even when plugged in without battery Check "Energy Saver" feature last week
@ uazo uazo added the task label last week

Uazo commented last week

question: but how do you know about this battery mode if it was only introduced in v122?

https://chromium-review.googlesource.com/c/chromium/src/+/5046375

@ uazo
Owner

"It's not clear what the energy saver option exactly does"
perhaps energy saver helps limit user data collection and limits background processes.

currently (v120) that setting does nothing in blink, so websites have no way of knowing whether the device has a low battery, if they were able to derive it via javascript. the value is not exposed in any API but theoretically it could be deduced I think based on the response time of some code.

in android does not change anything, while on windows and chromeos it reduces the refresh rate.
linux does not really have battery management.

with v122 blink is also informed and warns v8 by enabling SetBatterySaverMode in isolates: unfortunately I don't know what it does because I didn't checkout code 122. that behaviour will be active with a new flag kBatterySaverModeRenderTuning disabled by default (for "now").

but since popular web browsers disable this option when plugged in

I'd like to know where you saw it.

When unplugged, user can enable "Energy Saver"

are you referring to the os or the browser?

some refs (for me):

chrome/browser/performance_manager/user_tuning/user_tuning_utils.cc
chrome/browser/performance_manager/user_tuning/battery_saver_mode_manager.cc
kPerformanceControlsSidePanel
@ uazo uazo added enhancement and removed task labels last week
@ uazo uazo changed the title Check "Energy Saver" feature Disable Blink "Energy Saver" feature in v122 last week

drimisssss commented last week
Oahh we didn't know that v122 introduce new flags and features about energy saver !
it's exciting and it becomes necessary for ecological issues and also economical so that web browsers do not consume too many resources and deactivate user tracking services.... it must be the norm and even the law !

drimisssss commented last week •
When plugged in, the energy saver option disappears completely, my battery is worn out and I removed battery completely from my Windows 10 laptop and I even disabled the windows power drivers in the device manager so the option "energy saver" never appears in Cromite, chrome, brave, chromium, yandex....

but on edge browser, I can activate energy saver and also on opera browser, I can activate energy saver even when plugged in....

"When unplugged, user can enable "Energy Saver"
i am referring to the computer, when computer is not any more plugged into the power supply, and the battery level reaches 20%, energy saver is automatically activated in browser

Oahh we didn't know that v122 introduce new flags and features about energy saver !

me neither. by the way, this is one of the biggest problems I have, namely how to know what the chromium team is doing (and where)

it becomes necessary for ecological issues
it must be the norm and even the law !

Uazo
hard to disagree, but I don't think activating that option by default will make a difference, and in any case it is not for me to decide. I do more damage by leaving a server on all the time, but if I don't, goodbye cromite.

in principle, privacy comes first, even before the environment: therefore, it is correct to leave the option but it should not be active by default, sorry.

I can activate energy saver even when plugged in....

this can be implemented

i am referring to the computer

ok, I thought you were referring to android

drimisssss commented 5 days ago •
"this can be implemented" : Great !! Thank you so much @uazo :) "

Describe alternatives you have considered
Microsoft edge, opera browser with their option energy saver even plugged in

Describe alternatives you have considered

Edge browser or opera browser or chromium 122

@PF4Public

This comment was marked as off-topic.

@azogggg

This comment was marked as off-topic.

@feraritn
Copy link

feraritn commented May 9, 2024

Hello, thank you so much Mr @uazo for the new awesome patch : " WIN enable HighEfficiencyMode by default " !

So this incredible option is now enabled by default in Cromite Browser even if we removed our old battery from our old notebook that has no battery anymore ?

I ask this question because I go to the section:

chrome://settings/performance

and I don't see an activatable option: "Enable battery saver even when plugged in"

image

@uazo
Copy link
Owner

uazo commented May 9, 2024

and I don't see an activatable option: "Enable battery saver even when plugged in"

no, the patch does exactly the opposite. it disables battery mode by default, being a mechanism that can be used as a fingerpriting bit.

@feraritn
Copy link

feraritn commented May 9, 2024

Interesting, we didn't know this feature can be used as a fingerpriting bit ! Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
working on it working on it
Projects
None yet
Development

No branches or pull requests

5 participants