Group Sync with Canvas Not Working Properly

[timkato]

UBC PRB0043608
After initial student group sync from Canvas to iPeer; subsequent re-syncs of student groups (if any changes in Canvas groups) are not synced properly (for example some students appearing in iPeer groups twice)

Steps to reproduce:

1. Create multiple student groups in Canvas course
2. Sync iPeer and Canvas groups
3. Move student from group A to group B in Canvas course
4. iPeer > attempt to re-sync Canvas group (select all Canvas groups, choose Replace group rather than merge)

[wynnset]

I have verified the bug. As a temporary workaround, you can delete all the groups in iPeer and then do the sync again.

I already have a working fix for this bug, but I just need you to confirm what happens in the case where you do what you explain above, except in step 4, you do not select the "Replace group..." checkbox.

i.e. You have these groups after step 3:

Group	iPeer Members	Canvas Members
Group A	Joe, Mark	Joe
Group B	Alice	Alice, Mark

There are 2 possible options for what happens after step 4 is performed (without checking the checkbox):

1. We would keep Mark in Group A and also add him into Group B (this is the current functionality)
2. We would show an error message saying that Mark is already in another group

Note that iPeer, unlike Canvas, allows the same member to exist in more than 1 group. So option 1 is totally a valid solution, and it's how it's currently implemented as I think it makes the most sense. Let me know if this makes sense to you as well, then we can push an update.

[wynnset]

As per our meeting today, we will soon be taking out the "merge" option, so I no longer need an answer for the above. We will keep things as-is until that option is removed.