For Edx Review #27
For Edx Review #27
Conversation
Stats is just stored in a field with scope of settings. The stats is updated everytime somebody submits an answer. Found out that the XBlock.json_handler annotation only works for POST requests, will return method not allowed if we try to use GET.
This simply changes where the original and revised answers are stored.
Other students' answers are now shown in the revise stage. Only the option that the other student selected is shown. Student's answers are put into a limited size pool. The pool is stored as an xblock field. This is meant to provide faster access than having to read every submission from students. The current pool management scheme is simple. All submissions are entered into the pool until the pool is filled up. Once the pool is filled up, a random entry selected for eviction to make room for new submissions. The answer selection for presenting to the user is also simple. For every option, we select a random student who selected that option.
…ensure the studio and student views share a similar visual style
… on the studio/student view
ADD instructions text below other responses ADD instructions to revise answer
The answer options was limited to 3 options only. This commit allows you to add and remove options so that you can have any number of options. As part of this, the edit page was also converted to Angular.
The algorithm is used to selecting student responses to be presented to the students. Instructors can choose different algorithm based on their pedagogy.
In order to validate the seeds, it requires seeds data, options and algorithm, which are the most part of them form. And also validating the whole form as a model is easier in the asyncValidator as there is no need to referencing the data in other models.
…r the advanced video panel look like
CHANGE from a button tag to an anchor to allow the icon
| <input type="text" name="question-text-image-url" id="question-text-image-url-{{$index}}" class="input setting-input pi-options image-input-url" ng-model="esc.data.options[$index].image_url" ng-model-options="{ debounce: 500 }" required/> <br /> | ||
| <label class="label setting-label pi-setting-label" for="question-text-image-url-{{$index}}">Image Position<span class="tip setting-help">Choose if you want the image to appear above or below the question text.</span></label> | ||
| <select name="question-text-image-position" id="question-text-image-position-{{$index}}" ng-model="esc.data.options[$index].image_position" ng-options="position as desc for (position, desc) in esc.image_position_locations"></select><br /> | ||
| <label class="label setting-label pi-setting-label" for="question-text-image-alt-{{$index}}">Image Description<span class="tip setting-help">Please provide alternative text for this image.</span></label> |
There was a problem hiding this comment.
Nit: is it possible to get the helper text on the next line?
There was a problem hiding this comment.
Thanks for finding this. My monitor isn't big enough to see that :)
|
Feedback on user UX regarding capitalization, punctuation, and instruction clarity:
|
| ) | ||
|
|
||
| # Declare that we are part of the grading System | ||
| has_score = True |
There was a problem hiding this comment.
Why do you want to be part of the grading system?
You don't give instructors the ability to set a different level of score.
Further, every time you do grading runs (generating certificates or pulling user data), or users visit the progress page, every single PI XBlock will be instantiated per student to get their state and score.
If you set this to False, our most critical performance concerns evaporate --- the progress page is the single longest load page in the system, so we're very conscious of adding more time to this load.
There was a problem hiding this comment.
Right now, we only give students a participation grade. so it will either 0 or 1. That's why there is no level of score.
I wouldn't expect there will be a lot of PI block instances for a course, if that makes any difference.
I think we might be able to live without the score for this term. However, we still want to in the long term. Maybe we can add it to your discussion list below.
|
Does your block emit Analytics events? Have we discussed that yet? |
|
@xcompass I'm ok with the block as it currently is for an Edge release only. Would you like to update your PR against edx-platform to reflect the current version of the block, and we can get that into Friday's release candidate? We can continue the conversation on all the things I've brought up today, but that doesn't have to block on Edge. The three outstanding issues I have are analytics eventing, accessibility, and documentation. |
Also added default seeds so that default question passes validation
No and No. But we would like to do it. Though I need more details or some examples. |
|
@sarina made the changes based on your feedbacks today. Released a new version and PR on edx-platform is updated. |
…ds. A preposition is something a sentence shouldn't end with.
…ront-end CHANGED the label styling so it matches the LMS in Studio
…d 'initially' as that allows us to reuse the template and also prevent confusion)
Change the grammar of the default question.
Normalize lms and studio styles
…-revised-answer-text
…ross-components # Conflicts: # ubcpi/static/css/ubcpi.css
Change the text shown with regards to which option you chose
Change checkbox labels to share similar styling to normal question styles
|
0.4.4 merged. Close for now and will open new PR for new features |
For an exported test course: https://s3.amazonaws.com/edx-uploads-std/UBCPI_TestCourse.tar.gz