Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Publications can be added to projects no matter how many authors they have #377

Merged

Conversation

brisco17
Copy link
Contributor

@brisco17 brisco17 commented Mar 1, 2022

Resolves issue #283

  • If a publication is searched for by its ID in order to be added to a project, it will now be successfully added no matter how long its author field is.
  • Publications like this will have its author field truncated down to 1024 characters.

@aebruno aebruno requested a review from dsajdak March 3, 2022 20:08
Copy link
Contributor

@dsajdak dsajdak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes fixed the error for adding a publication with an author list longer than 1024 characters. However, once the publication is added, it can't be deleted.

puberror

@aebruno
Copy link
Member

aebruno commented Mar 4, 2022

This may be related to #247

@dsajdak
Copy link
Contributor

dsajdak commented Mar 9, 2022

This error was related to the mariaDB/mysql utf8 support. Other testing shows these changes are good so we're going to approve it and merge. We'll be recommending Postgres for better encoding support, specifically for scientific and math characters frequently used in publication titles.

@aebruno aebruno merged commit 67f5d76 into ubccr:master Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants