Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync stack description #132

Merged
merged 8 commits into from
Jul 11, 2020
Merged

Sync stack description #132

merged 8 commits into from
Jul 11, 2020

Conversation

johnagl
Copy link
Contributor

@johnagl johnagl commented Jun 26, 2020

Related Tickets

Closes #128

Changes

Document sync stack (stuff on Redis not finished). @srijonsaha edit/change as you please :D

Checklist

@johnagl johnagl requested review from a team as code owners June 26, 2020 05:20
@netlify
Copy link

netlify bot commented Jun 26, 2020

Deploy preview is ready!

Built with commit f927e96

https://deploy-preview-132--ubclaunchpad-docs.netlify.app

Copy link
Member

@bobheadxi bobheadxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start, thanks for working on this @johnagl ! Left a few comments :)

resources/groundwork/web.md Outdated Show resolved Hide resolved
resources/groundwork/web.md Outdated Show resolved Hide resolved
resources/groundwork/web.md Outdated Show resolved Hide resolved
resources/groundwork/web.md Outdated Show resolved Hide resolved
resources/groundwork/web.md Outdated Show resolved Hide resolved
@bobheadxi bobheadxi marked this pull request as draft July 2, 2020 06:12
@bobheadxi bobheadxi changed the title Sync stack description (draft) Sync stack description Jul 2, 2020
@bobheadxi
Copy link
Member

Thanks for following up on my comments @johnagl :) what's here looks good, but I've marked it as a a draft for now - just mark the PR as ready for review whenever you're ready!

@bobheadxi
Copy link
Member

lmao this damn timing

image

@johnagl
Copy link
Contributor Author

johnagl commented Jul 2, 2020

lmao this damn timing

image

Lol I thought I was going crazy for a moment.

@johnagl johnagl marked this pull request as ready for review July 2, 2020 06:20
@johnagl
Copy link
Contributor Author

johnagl commented Jul 2, 2020

Thanks for following up on my comments @johnagl :) what's here looks good, but I've marked it as a a draft for now - just mark the PR as ready for review whenever you're ready!

I think this is good for now, unless @srijonsaha wants to add anything.

Copy link
Member

@bobheadxi bobheadxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than some wording changes, looks good to go 😁 thanks for the writeup!

resources/groundwork/web.md Outdated Show resolved Hide resolved
resources/groundwork/web.md Outdated Show resolved Hide resolved
@bobheadxi
Copy link
Member

Merging this for now :) Let's make adjustments in further PRs if needed

@bobheadxi bobheadxi merged commit efdfa8c into master Jul 11, 2020
@bobheadxi bobheadxi deleted the syncstack branch July 11, 2020 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

document Sync stack
2 participants