Skip to content

Commit

Permalink
Revert boostrap order change
Browse files Browse the repository at this point in the history
Added comment explaining why.
  • Loading branch information
bobheadxi committed Mar 23, 2018
1 parent 6b58dfb commit 91f7f26
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 8 deletions.
14 changes: 8 additions & 6 deletions client/remote.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,22 +58,24 @@ func (remote *RemoteVPS) Bootstrap(runner SSHSession, name string, config *Confi
return err
}

println("\n>> Step 3/4: Fetching daemon API token...")
token, err := remote.getDaemonAPIToken(runner, config.Version)
// This step needs to run before any other commands that rely on
// the daemon image, since the daemon is loaded here.
println("\n>> Step 3/4: Starting daemon...")
if err != nil {
return err
}
remote.Daemon.Token = token
err = config.Write()
err = remote.DaemonUp(runner, config.Version, remote.IP, remote.Daemon.Port)
if err != nil {
return err
}

println("\n>> Step 4/4: Starting daemon...")
println("\n>> Step 4/4: Fetching daemon API token...")
token, err := remote.getDaemonAPIToken(runner, config.Version)
if err != nil {
return err
}
err = remote.DaemonUp(runner, config.Version, remote.IP, remote.Daemon.Port)
remote.Daemon.Token = token
err = config.Write()
if err != nil {
return err
}
Expand Down
4 changes: 2 additions & 2 deletions client/remote_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,8 @@ func TestBootstrap(t *testing.T) {
// Make sure all commands are formatted correctly
assert.Equal(t, string(dockerScript), session.Calls[0])
assert.Equal(t, string(keyScript), session.Calls[1])
assert.Equal(t, tokenScript, session.Calls[2])
assert.Equal(t, daemonScript, session.Calls[3])
assert.Equal(t, daemonScript, session.Calls[2])
assert.Equal(t, tokenScript, session.Calls[3])
}

func TestInstrumentedBootstrap(t *testing.T) {
Expand Down

0 comments on commit 91f7f26

Please sign in to comment.