Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websockets instead of plain requests #174

Closed
bobheadxi opened this issue Apr 21, 2018 · 2 comments
Closed

Websockets instead of plain requests #174

bobheadxi opened this issue Apr 21, 2018 · 2 comments
Assignees
Labels
:cmd command line and clientside functionality :daemon daemon and serverside functionality todo: priority do as soon as possible! type: refactor 🏡 code structure and architecture
Milestone

Comments

@bobheadxi
Copy link
Member

bobheadxi commented Apr 21, 2018

So we can get things like live build status, etc as well as a cleaner log implementation

However, not sure if actually needed

@bobheadxi bobheadxi added :cmd command line and clientside functionality :daemon daemon and serverside functionality todo: investigate more research required labels Apr 21, 2018
@bobheadxi bobheadxi added this to the v0.3.1 milestone Apr 26, 2018
@bobheadxi bobheadxi added the type: refactor 🏡 code structure and architecture label May 1, 2018
@bobheadxi
Copy link
Member Author

@bobheadxi
Copy link
Member Author

bobheadxi commented May 5, 2018

How the CLI prints messages:
https://github.com/ubclaunchpad/inertia/blob/master/deploy.go#L204

We want this on the daemon, and instead of printing it, broadcast each line over websockets

The daemon logger handles writing: https://github.com/ubclaunchpad/inertia/blob/master/daemon/inertia/logger.go

That logger manages writing to multiple sources and broadcasting HTTP request successes/failures. Whether it'll be needed going forward is up for debate

FlushRoutines are used together with the logger for parsing the raw Docker bytestream: https://github.com/ubclaunchpad/inertia/blob/master/common/util.go#L69

Example usage: https://github.com/ubclaunchpad/inertia/blob/master/daemon/inertia/project/build.go#L91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:cmd command line and clientside functionality :daemon daemon and serverside functionality todo: priority do as soon as possible! type: refactor 🏡 code structure and architecture
Projects
None yet
Development

No branches or pull requests

3 participants