Icon headers #272
Merged
Icon headers #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 23, 2018 13:56
- Icon header for container page - Icons from fontawesome.com
bobheadxi
reviewed
Jun 23, 2018
daemon/web/webpack.config.js
Outdated
| '/': { target: 'https://127.0.0.1:4303', secure: false }, | ||
| }, | ||
| // proxy: { | ||
| // '/': { target: 'https://127.0.0.1:4303', secure: false }, |
bobheadxi
requested changes
Jun 24, 2018
There was a problem hiding this comment.
I don't think the proxy should be removed - I used it last night, everything was working fine. Did you have issues with it?
Also a heads up that the linter is throwing heaps of complaints you'll have to fix before we land this PR:
/home/travis/gopath/src/github.com/ubclaunchpad/inertia/daemon/web/actions/dashboard.js
8:3 warning Unexpected console statement no-console
/home/travis/gopath/src/github.com/ubclaunchpad/inertia/daemon/web/actions/login.js
8:3 warning Unexpected console statement no-console
/home/travis/gopath/src/github.com/ubclaunchpad/inertia/daemon/web/actions/main.js
8:3 warning Unexpected console statement no-console
/home/travis/gopath/src/github.com/ubclaunchpad/inertia/daemon/web/components/IconHeader/IconHeader.js
6:1 error Expected indentation of 2 spaces but found 4 indent
6:16 error Empty components are self-closing react/self-closing-comp
7:1 error Expected indentation of 2 spaces but found 4 indent
7:17 error Empty components are self-closing react/self-closing-comp
8:1 error Expected indentation of 2 spaces but found 4 indent
8:11 error Empty components are self-closing react/self-closing-comp
9:1 error Expected indentation of 2 spaces but found 4 indent
9:15 error Empty components are self-closing react/self-closing-comp
9:45 error Missing trailing comma comma-dangle
12:30 error 'type' is missing in props validation react/prop-types
13:5 error Expected indentation of 2 space characters but found 4 react/jsx-indent
14:9 error Expected indentation of 6 space characters but found 8 react/jsx-indent
15:9 error Expected indentation of 6 space characters but found 8 react/jsx-indent
20:1 error Expected indentation of 2 spaces but found 4 indent
23:27 error Newline required at end of file but not found eol-last
/home/travis/gopath/src/github.com/ubclaunchpad/inertia/daemon/web/pages/containers/Containers.js
25:22 error Multiple spaces found before 'type' no-multi-spaces
25:27 error Unexpected usage of singlequote jsx-quotes
25:46 error Unexpected usage of singlequote jsx-quotes
25:57 error A space is required before closing bracket react/jsx-tag-spacing
/home/travis/gopath/src/github.com/ubclaunchpad/inertia/daemon/web/pages/login/Login.js
48:5 warning Unexpected console statement no-console
✖ 23 problems (19 errors, 4 warnings)
18 errors, 0 warnings potentially fixable with the `--fix` option.
Good work though, thanks for putting in the PR! 😄
bobheadxi
previously approved these changes
Jun 29, 2018
bobheadxi
approved these changes
Jun 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Ticket(s): Closes #249
👷 Changes
implemented icon header component
🔦 Testing Instructions